Skip to content

release-notes: check errors flagged by errcheck #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prestist merged 1 commit into from
Oct 28, 2026
+7 −7
Merged

release-notes: check errors flagged by errcheck #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions release-notes/tool/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func run(args []string, stdout io.Writer) error {
if err != nil {
return err
}
fmt.Fprintf(stdout, "Validated %d release-note fragment(s).\n", len(fragments))
_, _ = fmt.Fprintf(stdout, "Validated %d release-note fragment(s).\n", len(fragments))
return nil
case "preview":
if len(args) != 1 {
Expand All @@ -123,7 +123,7 @@ func run(args []string, stdout io.Writer) error {
if err := finalize(releaseNotesPath, fragments, args[1], args[2]); err != nil {
return err
}
fmt.Fprintf(stdout, "Finalized Ignition %s (%s) with %d release-note fragment(s).\n", args[1], args[2], len(fragments))
_, _ = fmt.Fprintf(stdout, "Finalized Ignition %s (%s) with %d release-note fragment(s).\n", args[1], args[2], len(fragments))
return nil
default:
return usageError()
Expand Down Expand Up @@ -305,7 +305,7 @@ func finalizeWithOps(notesPath string, fragments []fragment, version, date strin
if err != nil {
return err
}
defer os.Remove(temporaryPath)
defer func() { _ = os.Remove(temporaryPath) }()
if err := ops.beforeMutation(); err != nil {
return fmt.Errorf("preparing to update release notes: %w", err)
}
Expand Down Expand Up @@ -419,7 +419,7 @@ func readFileSnapshot(path string) ([]byte, os.FileMode, error) {
if err != nil {
return nil, 0, err
}
defer file.Close()
defer func() { _ = file.Close() }()
info, err := file.Stat()
if err != nil {
return nil, 0, err
Expand All @@ -439,8 +439,8 @@ func writeTemporaryFile(path string, data []byte, mode os.FileMode) (temporaryPa
temporaryPath = temporary.Name()
defer func() {
if retErr != nil {
temporary.Close()
os.Remove(temporaryPath)
_ = temporary.Close()
_ = os.Remove(temporaryPath)
}
}()
if err := temporary.Chmod(mode); err != nil {
Expand Down Expand Up @@ -529,7 +529,7 @@ func atomicReplace(path string, data []byte, mode os.FileMode) error {
if err != nil {
return err
}
defer os.Remove(temporaryPath)
defer func() { _ = os.Remove(temporaryPath) }()
if err := os.Rename(temporaryPath, path); err != nil {
return fmt.Errorf("replacing %q: %w", path, err)
}
Expand Down
Loading