Repository navigation
go/tests: fix ignition build command - #372
Merged
Merged
Conversation
Ignition's ./build script requires an argument (ignition, ignition-validate, butane, etc.) and fails when called bare. Use make instead, which runs the 'all' target and builds all binaries correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go_build_cmdfrom./buildtomakein the Go test template./buildscript requires an argument (e.g.ignition,ignition-validate,butane) and exits with an error when called baremake(with no target) runs thealltarget which invokes./buildwith each argument correctlyfedora-coreos-stream-generatorandstream-metadata-goalready usemakeFixes the CI breakage introduced by coreos/ignition#2287