tests: add raid1-boot test for ppc64le - #4207
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for testing RAID 1 boot on the ppc64le architecture. It introduces a new Butane configuration, a symlink to common data, and a test script for ppc64le, while updating the common library to handle the architecture's bootupctl components. The feedback points out a minor issue in the new test script where a comment incorrectly refers to 'Linear RAID' instead of 'RAID 1' and suggests a correction.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Nice. I imagine we'll need to denylist this test downstream OR does the grub there have the fix too? |
|
Likely we will need to denylist downstream until the fix shows up there too since AFAICT it's not there yet. Do you want me to open that before we merge this? |
|
Seems I'll need to do some more porting for rawhide and rhel. I'll get those done first so updates don't take too long. |
c4rt0
left a comment
c4rt0
left a comment
There was a problem hiding this comment.
Other than the comment, this LGTM
6c05e61 to
c3d6cfa
Compare
it would be useful to be pro-active about it, yes. this LGTM. Feel free to merge when you are ready. |
|
I'm thinking to wait until at least the rawhide package is updated so we don't need to denylist here. There's no rush for this as far as I know, but I'll be trying to get those patches ported as soon as I get the chance |
|
The rawhide update is available but we've been unable to pick it up in our builds due to coreos/fedora-coreos-tracker#2171. When that's resolved and rawhide passes this test, I'll open a PR to denylist downstream and merge this PR. |
|
Rawhide now passes this test. Opened coreos/rhel-coreos-config#281 for downstream, where I'll create a denylist entry. |
3 participants
Final piece in relation to coreos/fedora-coreos-tracker#2134.
With f697300, we now have the
grub2version which includes rhboot/grub2#212 (2.12-60.fc44). This test should now work as intended on our ppc64le builds.Confirmed the test passes with a ppc64le debug pod.