Skip to content

Stage releases from version tags using shared release actions - #293

Merged
ianmacartney merged 2 commits into
mainfrom
ian/tag-releases-shared-actions
Nov 18, 2026
Merged

ianmacartney merged 2 commits into
mainfrom
ian/tag-releases-shared-actions

Conversation

@ianmacartney

Copy link
Copy Markdown
Member

Moves releases to the tag-triggered flow, using the shared actions in convex/npm-release-actions (pinned by SHA, v0.2.0), as already done in convex/action-cache and convex/sharded-counter.

  • When a new version reaches main (for example, the version PR merges), the version workflow tags the commit that set it as v<version> and starts Release on that tag. Pushing a tag by hand also starts Release.
  • Release builds exactly the tagged commit, so npm provenance names the commit that was built. The build job (no npm credentials) validates the tag, checks release notes, builds, runs checks and the E2E/codegen check, and packs. The stage job verifies the tarball's SHA-256 and runs npm stage publish without a checkout.
  • The version PR job uses the shared version-pr action, which also updates package-lock.json's version.
  • Removes push-history scanning, the manual commit input, the GITHUB_SHA override and post-stage tagging.
  • CONTRIBUTING covers the new flow and recovery.

Release runs on v<version> tags, or on a tag the version workflow creates
when a new version reaches main, and builds exactly the tagged commit so
npm provenance matches. Use the shared npm-release-actions for tag
validation, release notes, packing, staging, the version PR and tagging.
Remove push-history scanning, the manual commit input and post-stage
tagging.
@pkg-pr-new

pkg-pr-new Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@convex-dev/aggregate@293

commit: 2d00801

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/version.yml">

<violation number="1" location=".github/workflows/version.yml:50">
P2: This tag job can release the wrong commit: a later `main` push replaces a pending workflow run before this job executes, so `tag-version` tags that later `${{ github.sha }}`. Run tagging separately from the serialized version-PR workflow, or otherwise preserve each version-bump commit until its tag is created.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

ref: ${{ github.sha }}
fetch-depth: 0
persist-credentials: false
- uses: convex/npm-release-actions/tag-version@6d8758603978f892ffbdcd1a170b8b0c121efefe # v0.2.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This tag job can release the wrong commit: a later main push replaces a pending workflow run before this job executes, so tag-version tags that later ${{ github.sha }}. Run tagging separately from the serialized version-PR workflow, or otherwise preserve each version-bump commit until its tag is created.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/version.yml, line 50:

<comment>This tag job can release the wrong commit: a later `main` push replaces a pending workflow run before this job executes, so `tag-version` tags that later `${{ github.sha }}`. Run tagging separately from the serialized version-PR workflow, or otherwise preserve each version-bump commit until its tag is created.</comment>

<file context>
@@ -31,29 +31,20 @@ jobs:
+          ref: ${{ github.sha }}
+          fetch-depth: 0
+          persist-credentials: false
+      - uses: convex/npm-release-actions/tag-version@6d8758603978f892ffbdcd1a170b8b0c121efefe # v0.2.0
</file context>

Without queue: max, a newer push replaces a pending run, so two version
PRs merged back to back could leave the first version untagged.
@ianmacartney
ianmacartney merged commit c3c9e30 into main Nov 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant