Repository navigation
Stage releases from version tags using shared release actions - #293
Merged
Merged
Conversation
Release runs on v<version> tags, or on a tag the version workflow creates when a new version reaches main, and builds exactly the tagged commit so npm provenance matches. Use the shared npm-release-actions for tag validation, release notes, packing, staging, the version PR and tagging. Remove push-history scanning, the manual commit input and post-stage tagging.
commit: |
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/version.yml">
<violation number="1" location=".github/workflows/version.yml:50">
P2: This tag job can release the wrong commit: a later `main` push replaces a pending workflow run before this job executes, so `tag-version` tags that later `${{ github.sha }}`. Run tagging separately from the serialized version-PR workflow, or otherwise preserve each version-bump commit until its tag is created.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| ref: ${{ github.sha }} | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| - uses: convex/npm-release-actions/tag-version@6d8758603978f892ffbdcd1a170b8b0c121efefe # v0.2.0 |
There was a problem hiding this comment.
P2: This tag job can release the wrong commit: a later main push replaces a pending workflow run before this job executes, so tag-version tags that later ${{ github.sha }}. Run tagging separately from the serialized version-PR workflow, or otherwise preserve each version-bump commit until its tag is created.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/version.yml, line 50:
<comment>This tag job can release the wrong commit: a later `main` push replaces a pending workflow run before this job executes, so `tag-version` tags that later `${{ github.sha }}`. Run tagging separately from the serialized version-PR workflow, or otherwise preserve each version-bump commit until its tag is created.</comment>
<file context>
@@ -31,29 +31,20 @@ jobs:
+ ref: ${{ github.sha }}
+ fetch-depth: 0
+ persist-credentials: false
+ - uses: convex/npm-release-actions/tag-version@6d8758603978f892ffbdcd1a170b8b0c121efefe # v0.2.0
</file context>
Without queue: max, a newer push replaces a pending run, so two version PRs merged back to back could leave the first version untagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves releases to the tag-triggered flow, using the shared actions in convex/npm-release-actions (pinned by SHA, v0.2.0), as already done in convex/action-cache and convex/sharded-counter.
main(for example, the version PR merges), the version workflow tags the commit that set it asv<version>and starts Release on that tag. Pushing a tag by hand also starts Release.npm stage publishwithout a checkout.version-praction, which also updatespackage-lock.json's version.GITHUB_SHAoverride and post-stage tagging.