libartifact: introduce handling of artifact store events#768
Open
nimdrak wants to merge 4 commits intocontainers:mainfrom
Open
libartifact: introduce handling of artifact store events#768nimdrak wants to merge 4 commits intocontainers:mainfrom
nimdrak wants to merge 4 commits intocontainers:mainfrom
Conversation
nimdrak
force-pushed
the
introduce_an_event_channel_for_artifactstore
branch
from
4066258 to
0afac95
Compare
nimdrak
changed the title
|
Packit jobs failed. @containers/packit-build please check. |
nimdrak
changed the title
nimdrak
changed the title
nimdrak
force-pushed
the
introduce_an_event_channel_for_artifactstore
branch
from
0afac95 to
3ee8036
Compare
Signed-off-by: Byounguk Lee <nimdrak@gmail.com>
Signed-off-by: Byounguk Lee <nimdrak@gmail.com>
nimdrak
force-pushed
the
introduce_an_event_channel_for_artifactstore
branch
from
4f53335 to
6362450
Compare
- Introduced withLockedLayout and copyArtifact helpers to resolve dupl lint issues. - Maintained the original thread-locking scope for as.storePath access. - Fixed a resource leak by ensuring the copier is always closed using defer and capturing the close error. Signed-off-by: Byounguk Lee <nimdrak@gmail.com>
nimdrak
force-pushed
the
introduce_an_event_channel_for_artifactstore
branch
from
ec94ce0 to
1770e3d
Compare
nimdrak
changed the title
…annel - TestArtifactStore_EventChannel deals with the cases: AddSuccessAndAddError, RemoveSuccess, PushError, PullError Signed-off-by: Byounguk Lee <nimdrak@gmail.com>
nimdrak
force-pushed
the
introduce_an_event_channel_for_artifactstore
branch
from
1770e3d to
8afbf4d
Compare
baude
reviewed
Apr 20, 2026
| // EventTypeArtifactPull represents an artifact pull. | ||
| EventTypeArtifactPull | ||
| // EventTypeArtifactPullError represents a failed artifact pull. | ||
| EventTypeArtifactPullError |
Member
There was a problem hiding this comment.
Is this new? Do we report errors as events?
Author
There was a problem hiding this comment.
Yes, some of these are new.
Our podman/libpod and container-libs/common/libimage only handles PullError
I thought it would be beneficial to notify clients about other errors as well, such as AddError, RemoveError, and PushError. And I also add
However, if there's a specific reason why we only track PullError, I am completely open to removing these new additions.
What do you think?
Author
There was a problem hiding this comment.
While I introduced AddEvent, I intentionally left out other events like Extract and Inspect. These are new too, but I only added AddEvent since it's the only one that actually modifies the artifact store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #465