-
Notifications
You must be signed in to change notification settings - Fork 123
all: Fix broken links and add GitHub Actions workflow for link checking #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
781fd13
676a708
b956449
29f3bba
61589c1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ which apply to all containerd projects. | |
|
|
||
| ## Setting up your local environment | ||
|
|
||
| At a minimum, the Rust toolchain. When using `rustup` the correct toolchain version is picked up from the [rust-toolchain.toml](./rust-toolchain.toml) so you don't need to worry about the version. | ||
| At a minimum, the Rust toolchain. When using `rustup` the correct toolchain version is picked up from the [rust-toolchain.toml](https://github.com/containerd/runwasi/blob/main/rust-toolchain.toml) file so you don't need to worry about the version. | ||
|
|
||
| > ``` | ||
| > curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh | ||
|
|
@@ -29,7 +29,7 @@ If on Windows use (use [git BASH](https://gitforwindows.org/) terminal which has | |
| ./scripts/setup-windows.sh | ||
| ``` | ||
|
|
||
| If you choose to always build with `cross`, you don't need any of these requirements above as they will be provided via the cross container. This does require `docker` or `podman`. Refer to the [cross getting started page](https://github.com/cross-rs/cross/wiki/Getting-Started) for more details. | ||
| If you choose to always build with [cross](https://github.com/cross-rs/cross), you don't need any of these requirements above as they will be provided via the cross container. This does require `docker` or `podman`. Refer to the [cross getting started page](https://github.com/cross-rs/cross/wiki/Getting-Started) for more details. | ||
|
|
||
| Install cross: | ||
|
|
||
|
|
@@ -39,7 +39,7 @@ scripts/setup-cross.sh | |
|
|
||
| ## Project structure and architecture | ||
|
|
||
| For a detailed overview of the Runwasi structure and architecture, please refer to the [Architecture Documentation](./docs/src/user-guide/architecture.md). | ||
| For a detailed overview of the Runwasi structure and architecture, please refer to the [Architecture Documentation](https://runwasi.dev/developer/architecture.html). | ||
|
|
||
| The documentation covers: | ||
| - High-level structure of Runwasi | ||
|
|
@@ -61,7 +61,7 @@ To build a shim for specific runtime (wasmtime, wasmer, wasmedge, wamr, etc): | |
| make build-<runtime> | ||
| ``` | ||
|
|
||
| By default the runtimes will build for your current OS and architecture. If you want to build for a specific OS and architecture you can specify `TARGET`, where it matches a target in [Cross.toml](./Cross.toml). If your target doesn't match your host OS and architecture [Cross](https://github.com/cross-rs/cross) will be used. As an example will build a static binary: | ||
| By default the runtimes will build for your current OS and architecture. If you want to build for a specific OS and architecture you can specify `TARGET`, where it matches a target in "Cross.toml". If your target doesn't match your host OS and architecture [Cross](https://github.com/cross-rs/cross) will be used. As an example will build a static binary: | ||
|
Mossaka marked this conversation as resolved.
|
||
|
|
||
| ``` | ||
| TARGET=x86_64-unknown-linux-musl make build | ||
|
|
@@ -71,7 +71,7 @@ TARGET=x86_64-unknown-linux-musl make build | |
|
|
||
| ### Unit tests | ||
|
|
||
| Unit tests are run via `make test` or for a specific runtime `make test-<runtime>`. On linux the tests will run using `sudo`. This is configured in the `runner` field in [.cargo/config.toml](./.cargo/config.toml) | ||
| Unit tests are run via `make test` or for a specific runtime `make test-<runtime>`. On linux the tests will run using `sudo`. This is configured in the `runner` field in ".cargo/config.toml" | ||
|
|
||
| You should see some output like: | ||
| ```terminal | ||
|
|
@@ -90,9 +90,9 @@ RUST_LOG=DEBUG cargo test --package containerd-shim-wasmtime --lib -- wasmtime_t | |
|
|
||
| ### End to End tests | ||
|
|
||
| The e2e test run on [k3s](https://k3s.io/) and [kind](https://kind.sigs.k8s.io/). A test image is built using [oci-tar-builder](./crates/oci-tar-builder/) and is loaded onto the clusters. This test image is not pushed to an external registry so be sure to use the Makefile targets to build the image and load it on the cluster. | ||
| The e2e test run on [k3s](https://k3s.io/) and [kind](https://kind.sigs.k8s.io/). A test image is built using [oci-tar-builder](https://github.com/containerd/runwasi/tree/main/crates/oci-tar-builder) and is loaded onto the clusters. This test image is not pushed to an external registry so be sure to use the Makefile targets to build the image and load it on the cluster. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think floating links like this would be most desirable in the docs since a PR moving or removing the file should cause a failure of the link check.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what are floating links? Do you mean links like |
||
|
|
||
| The deployment file in [test/k8s/Dockerfile](./test/k8s/Dockerfile) is run and verified that it deploys and runs successfully. To execute the e2e tests in either kind or k3s: | ||
| The deployment file in [test/k8s/Dockerfile](https://github.com/containerd/runwasi/blob/main/test/k8s/Dockerfile) is run and verified that it deploys and runs successfully. To execute the e2e tests in either kind or k3s: | ||
|
|
||
| ``` | ||
| make test/k8s-<runtime> # runs using kind | ||
|
|
@@ -107,7 +107,7 @@ make test/k8s-oci-<runtime> | |
|
|
||
| ### Building the test image | ||
|
|
||
| This builds a [wasm application](crates/wasi-demo-app/) and packages it in an OCI format: | ||
| This builds a [wasm application](https://github.com/containerd/runwasi/tree/main/crates/wasi-demo-app/) and packages it in an OCI format: | ||
|
|
||
| ``` | ||
| make test-image | ||
|
|
@@ -133,7 +133,7 @@ Most features will likely have most of the code in the `containerd-shim-wasm` pr | |
|
|
||
| A tip for developing a new feature is to implement it and test it with one runtime you are familiar with then add it to all the runtimes. This makes it easier to test and iterate before making changes across all the runtimes. | ||
|
|
||
| Any changes made to the `containerd-shim-wasm` crate needs to be documented in the [CHANGELOG.md](./crates/containerd-shim-wasm/CHANGELOG.md) file following the [Keep a Changelog](https://keepachangelog.com/en/1.1.0/) format. | ||
| Any changes made to the `containerd-shim-wasm` crate needs to be documented in the [CHANGELOG.md](https://github.com/containerd/runwasi/blob/main/crates/containerd-shim-wasm/CHANGELOG.md) file following the [Keep a Changelog](https://keepachangelog.com/en/1.1.0/) format. | ||
|
|
||
| ## Adding new shims | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,4 +63,4 @@ Check out these projects that build on top of runwasi: | |
|
|
||
| ## Contributing | ||
|
|
||
| To begin contributing, please read our [Contributing Guide](https://runwasi.dev/developer/contributing.html). | ||
| To begin contributing, please read our [Contributing Guide](https://runwasi.dev/CONTRIBUTING.html). | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think anything based on checking runwasi.dev will fail only after runwasi.dev is deployed.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about a two phase linking strategy?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To elaborate more on the second point, I've added a action to create a GitHub issue for broken links it finds at post-deployment of runwasi.dev. |
||
Uh oh!
There was an error while loading. Please reload this page.