Add WithPluginDirsAndCacheDir option and deprecate WithPluginDir option#135
Open
Voldemat wants to merge 1 commit intocontainerd:mainfrom
Open
Add WithPluginDirsAndCacheDir option and deprecate WithPluginDir option#135Voldemat wants to merge 1 commit intocontainerd:mainfrom
Voldemat wants to merge 1 commit intocontainerd:mainfrom
Conversation
Signed-off-by: Vladimir Voitenko <vladimirdev635@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now there is no way to configure cni cache directory from containerd, libcni already upstreamed ability to configure it through new CNIConfig constructor function NewCNIConfigWithCacheDir. If we want same behavior as before, we can just set cacheDir argument to empty string as I noted in documentation string before WithPluginDirsAndCacheDir function.
This change would allow containerd to then set this cache dir from configuration file.