Skip to content

Fix the number of transactions added by Sphere graph builder#2506

Open
Auriga2 wants to merge 2 commits into
masterfrom
bugfix/sphere_graph_transactions
Open

Fix the number of transactions added by Sphere graph builder#2506
Auriga2 wants to merge 2 commits into
masterfrom
bugfix/sphere_graph_transactions

Conversation

@Auriga2

@Auriga2 Auriga2 commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Prerequisites

  • Reviewed the checklist

  • Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
    for the "CI / Unit Tests") to complete first. Failed Unit tests can be
    debugged by adding the label "verbose logging" to the GitHub PR.

Description of the Change

Fixed the Sphere graph builder which was creating extra transactions than the user specified.
39 additional transactions were added when Explicit loops option is unchecked. Otherwise 43 additional transactions were added.

Alternate Designs

Why Should This Be In Core?

Benefits

Possible Drawbacks

Verification Process

  • Open consty and create a new empty graph
  • Experimental->Build Graph->Sphere Graph Builder
  • Change "Number of Transactions" to any value, keeping other options with default values, then click "Build"
  • Verify the created graph has no 43 extra transactions, visible in the bottom right corner of constellation.
  • Uncheck "Explicit loops" and repeat. Verify 39 additional transactions are not added.

Applicable Issues

#2478

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@antares1470 antares1470 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the sphere graph builder 3 times, with the default 100 nodes and 50 transactions

  • the 1st run it made a graph with 42 transactions
  • the 2nd run it made a graph with 50 transactions
  • the 3rd run it made a graph with 25 transactions

So there might be something wrong with how its creating transactions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants