Fix the number of transactions added by Sphere graph builder#2506
Open
Auriga2 wants to merge 2 commits into
Open
Fix the number of transactions added by Sphere graph builder#2506Auriga2 wants to merge 2 commits into
Auriga2 wants to merge 2 commits into
Conversation
|
antares1470
requested changes
May 28, 2026
antares1470
left a comment
Collaborator
There was a problem hiding this comment.
Ran the sphere graph builder 3 times, with the default 100 nodes and 50 transactions
- the 1st run it made a graph with 42 transactions
- the 2nd run it made a graph with 50 transactions
- the 3rd run it made a graph with 25 transactions
So there might be something wrong with how its creating transactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Prerequisites
Reviewed the checklist
Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
for the "CI / Unit Tests") to complete first. Failed Unit tests can be
debugged by adding the label "verbose logging" to the GitHub PR.
Description of the Change
Fixed the Sphere graph builder which was creating extra transactions than the user specified.
39 additional transactions were added when Explicit loops option is unchecked. Otherwise 43 additional transactions were added.
Alternate Designs
Why Should This Be In Core?
Benefits
Possible Drawbacks
Verification Process
Applicable Issues
#2478