Add options to dock/float views in preferences

CoreAnalyticView/src/au/gov/asd/tac/constellation/views/analyticview/AnalyticViewTopComponent.java

@@ -67,7 +67,7 @@
     "HINT_AnalyticViewTopComponent=Analytic View"
 })
 public final class AnalyticViewTopComponent extends JavaFxTopComponent<AnalyticViewPane> {
-    
+
     private static final String ANALYTIC_VIEW_GRAPH_CHANGED_THREAD_NAME = "Analytic View Graph Changed Updater";
     private final AnalyticViewPane analyticViewPane;
     private final AnalyticViewController analyticController;
@@ -127,7 +127,7 @@ public AnalyticViewTopComponent() {
                 analyticViewPane.getConfigurationPane().updateSelectablePluginsParameters();
             }
         }));
-        
+
         refreshRunnable = () -> {
             final List<Object> devNull = new ArrayList<>();
             while (!queue.isEmpty()) {
@@ -140,7 +140,9 @@ public AnalyticViewTopComponent() {
     }
 
     /**
-     * This method is called from within the constructor to initialize the form. WARNING: Do NOT modify this code. The content of this method is always regenerated by the Form Editor.
+     * This method is called from within the constructor to initialize the form.
+     * WARNING: Do NOT modify this code. The content of this method is always
+     * regenerated by the Form Editor.
      */
     // <editor-fold defaultstate="collapsed" desc="Generated Code">//GEN-BEGIN:initComponents
     private void initComponents() {
@@ -215,6 +217,8 @@ protected void handleComponentOpened() {
         if (activeGraph == null) {
             analyticViewPane.reset();
         }
+
+        setFloating(0, 0);
     }
 
     @Override
@@ -227,7 +231,7 @@ protected void componentShowing() {
         analyticController.readState();
         handleNewGraph(activeGraph);
     }
-    
+
     @Override
     protected void handleGraphChange(final GraphChangeEvent event) {
         if (event == null) { // can be null at this point in time

CoreAttributeEditorView/src/au/gov/asd/tac/constellation/views/attributeeditor/AttributeEditorTopComponent.java

@@ -136,7 +136,6 @@ public AttributeEditorTopComponent() {
 
         };
 
-
         GraphManager.getDefault().addGraphManagerListener(AttributeEditorTopComponent.this);
         newActiveGraph(GraphManager.getDefault().getActiveGraph());
         initContent();
@@ -175,12 +174,14 @@ protected void handleComponentOpened() {
         newActiveGraph(GraphManager.getDefault().getActiveGraph());
 
         PreferenceUtilities.addPreferenceChangeListener(prefs.absolutePath(), this);
-        
+
         // Ensure that all the 'Show Empty' buttons are toggled on when panel
         // is re-displayed
         if (attributePanel != null) {
             attributePanel.refreshShowEmpty();
         }
+
+        setFloating(0, 0);
     }
 
     @Override
@@ -267,7 +268,7 @@ protected String createStyle() {
     protected AttributeEditorPanel createContent() {
         return attributePanel;
     }
-    
+
     @Override
     protected void handlePreferenceChange(final PreferenceChangeEvent event) {
         if (reader != null) {

CoreConversationView/src/au/gov/asd/tac/constellation/views/conversationview/ConversationViewTopComponent.java

@@ -73,7 +73,7 @@ public ConversationViewTopComponent() {
         setName(Bundle.CTL_ConversationViewTopComponent());
         setToolTipText(Bundle.HINT_ConversationViewTopComponent());
         Platform.setImplicitExit(false);
-        controller = ConversationController.getDefault(); 
+        controller = ConversationController.getDefault();
         controller.getConversation().getGraphUpdateManager().setManaged(true);
         initContent();
     }
@@ -82,6 +82,7 @@ public ConversationViewTopComponent() {
     protected void handleComponentOpened() {
         super.handleComponentOpened();
         controller.getConversation().getGraphUpdateManager().setManaged(needsUpdate());
+        setFloating(0, 0);
     }
 
     @Override
@@ -117,12 +118,12 @@ protected String createStyle() {
     protected ConversationBox createContent() {
         return controller.getConversationBox();
     }
-    
+
     @Override
     protected void handleNewGraph(final Graph graph) {
         controller.updateComponent();
     }
-    
+
     /**
      * This method is called from within the constructor to initialize the form.
      * WARNING: Do NOT modify this code. The content of this method is always

CoreDataAccessView/src/au/gov/asd/tac/constellation/views/dataaccess/DataAccessViewTopComponent.java

@@ -82,7 +82,7 @@ public DataAccessViewTopComponent() {
 
         dataAccessPane = new DataAccessPane(this);
         dataAccessPane.addUIComponents();
-        
+
         // The data access pane that is initialized above is returned in the
         // overridden method getContent() below. That is how the initContent()
         // in the super class can reference it and add the data accees view to
@@ -106,7 +106,7 @@ public DataAccessViewTopComponent() {
     public DataAccessPane getDataAccessPane() {
         return dataAccessPane;
     }
-    
+
     /**
      * A fixed single thread pool for execution of jobs in the data access view
      * that need to happen in an asynchronous manner.
@@ -124,8 +124,8 @@ public DataAccessPane createContent() {
 
     @Override
     public String createStyle() {
-        return JavafxStyleManager.isDarkTheme() 
-                ? "resources/data-access-view-dark.css" 
+        return JavafxStyleManager.isDarkTheme()
+                ? "resources/data-access-view-dark.css"
                 : "resources/data-access-view-light.css";
     }
 
@@ -137,6 +137,7 @@ public void handleComponentOpened() {
         super.handleComponentOpened();
         manageQualityControlListeners(true);
         QualityControlAutoVetter.getInstance().addObserver(getDataAccessPane());
+        setFloating(0, 0);
     }
 
     /**
@@ -160,12 +161,12 @@ protected void handleNewGraph(final Graph graph) {
         System.setProperty("dav.graph.ready", Boolean.FALSE.toString());
         if (needsUpdate() && getDataAccessPane() != null) {
             getDataAccessPane().update(graph);
-            Platform.runLater(() -> 
-                DataAccessUtilities.loadDataAccessState(getDataAccessPane(), graph)
+            Platform.runLater(()
+                    -> DataAccessUtilities.loadDataAccessState(getDataAccessPane(), graph)
             );
         }
-        Platform.runLater(() ->
-                // nested runLater so it runs after all the other triggered processes for opening a graph have been run
+        Platform.runLater(()
+                -> // nested runLater so it runs after all the other triggered processes for opening a graph have been run
                 Platform.runLater(() -> System.setProperty("dav.graph.ready", Boolean.TRUE.toString()))
         );
     }

CoreErrorReportView/src/au/gov/asd/tac/constellation/views/errorreport/ErrorReportTopComponent.java

@@ -18,12 +18,10 @@
 import au.gov.asd.tac.constellation.utilities.color.ConstellationColor;
 import au.gov.asd.tac.constellation.utilities.icon.UserInterfaceIconProvider;
 import au.gov.asd.tac.constellation.utilities.javafx.JavafxStyleManager;
-import javafx.scene.layout.BorderPane;
 import au.gov.asd.tac.constellation.views.JavaFxTopComponent;
 import java.awt.Color;
 import java.awt.Image;
 import java.io.IOException;
-import javafx.scene.input.MouseEvent;
 import java.util.ArrayList;
 import java.util.Date;
 import java.util.List;
@@ -53,6 +51,8 @@
 import javafx.scene.control.Tooltip;
 import javafx.scene.image.ImageView;
 import javafx.scene.image.WritableImage;
+import javafx.scene.input.MouseEvent;
+import javafx.scene.layout.BorderPane;
 import javafx.scene.layout.FlowPane;
 import javafx.scene.layout.GridPane;
 import javafx.scene.layout.HBox;
@@ -498,10 +498,12 @@ protected ScrollPane.ScrollBarPolicy getVerticalScrollPolicy() {
     protected void handleComponentOpened() {
         errorReportRunning = true;
         ErrorReportDialogManager.getInstance().setErrorReportRunning(errorReportRunning);
+        setFloating(0, 0);
     }
 
     /**
-     * Return popup control to the ErrorReportDialogManager when this view is closed
+     * Return popup control to the ErrorReportDialogManager when this view is
+     * closed
      */
     @Override
     protected void handleComponentClosed() {
@@ -643,7 +645,7 @@ public void updateSessionErrorsBox(final int insertPos) {
                 refreshSessionErrors();
                 final Date nextFilterDate = new Date();
                 final int errCount = sessionErrors.size();
-                // rebuild                
+                // rebuild
                 sessionErrorsBox.getChildren().clear();
                 for (int i = 0; i < errCount; i++) {
                     boolean allowPopupDisplay = false;
@@ -685,7 +687,8 @@ public boolean isIconFlashing() {
     }
 
     /**
-     * enable or disable flashing of the alert icon, as well as flashing of the tab label
+     * enable or disable flashing of the alert icon, as well as flashing of the
+     * tab label
      *
      * @param enabled
      */
@@ -792,7 +795,8 @@ private List<String> getErrorLevelList(final boolean unAcknowledgedEntriesOnly)
     }
 
     /**
-     * Generate the TitledPane object containing the details for the error report entry.
+     * Generate the TitledPane object containing the details for the error
+     * report entry.
      *
      * @param entry
      * @return

CoreFindView/src/au/gov/asd/tac/constellation/views/find/FindViewTopComponent.java

@@ -22,14 +22,11 @@
 import au.gov.asd.tac.constellation.views.JavaFxTopComponent;
 import au.gov.asd.tac.constellation.views.find.components.FindViewPane;
 import au.gov.asd.tac.constellation.views.find.components.advanced.AdvancedCriteriaBorderPane;
-import java.awt.Dimension;
-import java.awt.Window;
 import org.openide.awt.ActionID;
 import org.openide.awt.ActionReference;
 import org.openide.awt.ActionReferences;
 import org.openide.util.NbBundle;
 import org.openide.windows.TopComponent;
-import org.openide.windows.WindowManager;
 
 /**
  * Find View Top Component.
@@ -72,28 +69,29 @@ public FindViewTopComponent() {
         setToolTipText(Bundle.HINT_FindViewTopComponent());
 
         /**
-         * initialize the FindViewController, initialize the Components of the topComponenet, set pane to a new
-         * FindViewPane and initialize the content.
+         * initialize the FindViewController, initialize the Components of the
+         * topComponenet, set pane to a new FindViewPane and initialize the
+         * content.
          */
         FindViewController.getDefault().init(this);
         initComponents();
         this.pane = new FindViewPane(this);
         initContent();
 
-        // Set the findView window to float
-        WindowManager.getDefault().setTopComponentFloating(this, true);
-
-        // View will be disable if no graphs are opened, enabled if otherwise
+        // View will be disabled if no graphs are opened, enabled if otherwise.
         disableFindView();
 
         /**
-         * This is called whenever a node or transaction is added or deleted. It resets the searching index back to the
-         * default to avoid index out of bounds issues when trying to find a node or transaction that no longer exists.
+         * This is called whenever a node or transaction is added or deleted. It
+         * resets the searching index back to the default to avoid index out of
+         * bounds issues when trying to find a node or transaction that no
+         * longer exists.
          */
         addStructureChangeHandler(graph -> FindViewController.getDefault().clearResultsLists());
 
         /**
-         * This updates the attribute list UI element when a attribute is added or removed from the graph.
+         * This updates the attribute list UI element when a attribute is added
+         * or removed from the graph.
          */
         addAttributeCountChangeHandler(graph -> UpdateUI());
 
@@ -120,8 +118,9 @@ protected String createStyle() {
     }
 
     /**
-     * Handles what occurs when the find view is closed. This updates the UI, to ensure its current and toggles the
-     * findview to set it to enabled or disabled based on if a graph is open.
+     * Handles what occurs when the find view is closed. This updates the UI, to
+     * ensure its current and toggles the findview to set it to enabled or
+     * disabled based on if a graph is open.
      */
     @Override
     protected void handleComponentClosed() {
@@ -131,31 +130,19 @@ protected void handleComponentClosed() {
     }
 
     /**
-     * Handles what occurs when the component is opened. This updates the UI to ensure its current, toggles the find
-     * view to set it to enabled or disabled based on if a graph is open, focuses the findTextBox for UX quality,
-     * ensures the view window is floating. It also sets the size and location of the view to be in the top right of the
-     * users screen.
+     * Handles what occurs when the component is opened. This updates the UI to
+     * ensure its current, toggles the find view to set it to enabled or
+     * disabled based on if a graph is open, focuses the findTextBox for UX
+     * quality, ensures the view window is floating. It also sets the size and
+     * location of the view to be in the top right of the users screen.
      */
     @Override
     protected void handleComponentOpened() {
         super.handleComponentOpened();
         UpdateUI();
         disableFindView();
         focusFindTextField();
-        WindowManager.getDefault().setTopComponentFloating(this, true);
-
-        this.setRequestFocusEnabled(true);
-
-        /**
-         * This loops through all the current windows and compares this top components top level ancestor with the
-         * windows parent. If they match the window is the find view so we set the size of the window.
-         */
-        for (final Window window : Window.getWindows()) {
-            if (this.getTopLevelAncestor() != null && this.getTopLevelAncestor().getName().equals(window.getName())) {
-                window.setMinimumSize(new Dimension(600, 350));
-                window.setSize(new Dimension(600, 350));
-            }
-        }
+        setFloating(600, 350);
     }
 
     /**
@@ -202,7 +189,8 @@ public FindViewPane getFindViewPane() {
     }
 
     /**
-     * Toggles the disabled state of the findView based on if any graphs are open.
+     * Toggles the disabled state of the findView based on if any graphs are
+     * open.
      */
     public void disableFindView() {
         getFindViewPane().setDisable(GraphManager.getDefault().getAllGraphs().isEmpty());
@@ -216,8 +204,8 @@ public void focusFindTextField() {
     }
 
     /**
-     * This calls all the necessary functions for each tab to update the attributes list based on what attributes are
-     * available for the user.
+     * This calls all the necessary functions for each tab to update the
+     * attributes list based on what attributes are available for the user.
      */
     public void UpdateUI() {
         // Update the basic find tab
@@ -236,8 +224,9 @@ public void UpdateUI() {
         final GraphElementType advancedType = GraphElementType.getValue(getFindViewPane().getTabs().getAdvancedFindTab().getLookForChoiceBox().getSelectionModel().getSelectedItem());
         for (final AdvancedCriteriaBorderPane criteriaPane : getFindViewPane().getTabs().getAdvancedFindTab().getCorrespondingCriteriaList(advancedType)) {
             /**
-             * set the updateUI variable to true. This avoids the change criteria pane function from occurring when re
-             * selecting the currently selected element after updating the attribute list
+             * set the updateUI variable to true. This avoids the change
+             * criteria pane function from occurring when re selecting the
+             * currently selected element after updating the attribute list
              */
             criteriaPane.setUpdateUI(true);
             criteriaPane.updateAttributesList(advancedType);
@@ -263,7 +252,6 @@ private void initComponents() {
         );
     }// </editor-fold>//GEN-END:initComponents
 
-
     // Variables declaration - do not modify//GEN-BEGIN:variables
     // End of variables declaration//GEN-END:variables
 }

CoreGraphNode/nbproject/genfiles.properties

@@ -1,8 +1,8 @@
-build.xml.data.CRC32=856b9c6f
+build.xml.data.CRC32=086632b7
 build.xml.script.CRC32=ab19df9f
 build.xml.stylesheet.CRC32=15ca8a54@2.95
 # This file is used by a NetBeans-based IDE to track changes in generated files such as build-impl.xml.
 # Do not edit this file. You may delete it but then the IDE will never regenerate such files for you.
-nbproject/build-impl.xml.data.CRC32=856b9c6f
+nbproject/build-impl.xml.data.CRC32=086632b7
 nbproject/build-impl.xml.script.CRC32=2a6ab1a9
 nbproject/build-impl.xml.stylesheet.CRC32=49aa68b0@2.95