Input Field Enhancments

CoreArrangementPlugins/src/au/gov/asd/tac/constellation/plugins/arrangements/time/LayerByTimePlugin.java

@@ -55,7 +55,7 @@
 import au.gov.asd.tac.constellation.plugins.templates.PluginTags;
 import au.gov.asd.tac.constellation.plugins.templates.SimpleReadPlugin;
 import au.gov.asd.tac.constellation.utilities.color.ConstellationColor;
-import au.gov.asd.tac.constellation.utilities.temporal.TimeZoneUtilities;
+import au.gov.asd.tac.constellation.utilities.temporal.TemporalUtilities;
 import java.awt.Color;
 import java.text.SimpleDateFormat;
 import java.time.Instant;
@@ -282,8 +282,8 @@ public void updateParameters(final Graph graph, final PluginParameters parameter
                         return;
                     }
 
-                    ZonedDateTime min = ZonedDateTime.ofInstant(Instant.now(), TimeZoneUtilities.UTC);
-                    ZonedDateTime max = ZonedDateTime.ofInstant(Instant.EPOCH, TimeZoneUtilities.UTC);
+                    ZonedDateTime min = ZonedDateTime.ofInstant(Instant.now(), TemporalUtilities.UTC);
+                    ZonedDateTime max = ZonedDateTime.ofInstant(Instant.EPOCH, TemporalUtilities.UTC);
                     final int txCount = rg.getTransactionCount();
                     boolean nonNullDateTimeFound = false;
                     for (int position = 0; position < txCount; position++) {

CoreAttributeEditorView/src/au/gov/asd/tac/constellation/views/attributeeditor/editors/DateTimeEditorFactory.java

@@ -18,7 +18,7 @@
 import au.gov.asd.tac.constellation.graph.attribute.ZonedDateTimeAttributeDescription;
 import au.gov.asd.tac.constellation.graph.attribute.interaction.ValueValidator;
 import au.gov.asd.tac.constellation.utilities.temporal.TemporalFormatting;
-import au.gov.asd.tac.constellation.utilities.temporal.TimeZoneUtilities;
+import au.gov.asd.tac.constellation.utilities.temporal.TemporalUtilities;
 import au.gov.asd.tac.constellation.views.attributeeditor.editors.operations.EditOperation;
 import java.time.LocalDate;
 import java.time.LocalTime;
@@ -153,7 +153,7 @@ protected Node createEditorControls() {
             final ObservableList<ZoneId> timeZones = FXCollections.observableArrayList();
             ZoneId.getAvailableZoneIds().forEach(id -> timeZones.add(ZoneId.of(id)));
             timeZoneComboBox = new ComboBox<>(timeZones.sorted(zoneIdComparator));
-            timeZoneComboBox.getSelectionModel().select(TimeZoneUtilities.UTC);
+            timeZoneComboBox.getSelectionModel().select(TemporalUtilities.UTC);
             timeZoneComboBox.getSelectionModel().selectedItemProperty().addListener(updateTimeFromZone);
 
             final Label timeZoneComboBoxLabel = new Label("Time Zone:");
@@ -165,15 +165,18 @@ protected Node createEditorControls() {
                 protected void updateItem(final ZoneId item, final boolean empty) {
                     super.updateItem(item, empty);
                     if (item != null) {
-                        setText(TimeZoneUtilities.getTimeZoneAsString(currentValue == null ? null : currentValue.toLocalDateTime(), item));
+                        setText(TemporalUtilities.getTimeZoneAsString(currentValue == null ? null : currentValue.toLocalDateTime(), item));
                     }
                 }
             };
             timeZoneComboBox.setCellFactory(cellFactory);
             timeZoneComboBox.setButtonCell(cellFactory.call(null));
-
-            final HBox timeZoneHbox = new HBox(CONTROLS_DEFAULT_HORIZONTAL_SPACING, 
-                    timeZoneComboBoxLabel, timeZoneComboBox);
+            timeZoneComboBox.getSelectionModel().select(TemporalUtilities.UTC);
+            timeZoneComboBox.getSelectionModel().selectedItemProperty().addListener(updateTimeFromZone);
+
+            final HBox timeZoneHbox = new HBox(timeZoneComboBoxLabel, timeZoneComboBox);
+            timeZoneHbox.setSpacing(5);
+
             final HBox timeSpinnerContainer = createTimeSpinners();
 
             final VBox controls = new VBox(CONTROLS_DEFAULT_VERTICAL_SPACING, 

CoreAttributeEditorView/src/au/gov/asd/tac/constellation/views/attributeeditor/editors/TimeZoneEditorFactory.java

@@ -17,7 +17,7 @@
 
 import au.gov.asd.tac.constellation.graph.attribute.TimeZoneAttributeDescription;
 import au.gov.asd.tac.constellation.graph.attribute.interaction.ValueValidator;
-import au.gov.asd.tac.constellation.utilities.temporal.TimeZoneUtilities;
+import au.gov.asd.tac.constellation.utilities.temporal.TemporalUtilities;
 import au.gov.asd.tac.constellation.views.attributeeditor.editors.operations.EditOperation;
 import java.time.ZoneId;
 import java.util.Comparator;
@@ -85,15 +85,15 @@ protected Node createEditorControls() {
             final ObservableList<ZoneId> timeZones = FXCollections.observableArrayList();
             ZoneId.getAvailableZoneIds().forEach(id -> timeZones.add(ZoneId.of(id)));
             timeZoneComboBox = new ComboBox<>(timeZones.sorted(zoneIdComparator));
-            timeZoneComboBox.getSelectionModel().select(TimeZoneUtilities.UTC);
+            timeZoneComboBox.getSelectionModel().select(TemporalUtilities.UTC);
             timeZoneComboBox.getSelectionModel().selectedItemProperty().addListener((o, n, v) -> update());
 
             final Callback<ListView<ZoneId>, ListCell<ZoneId>> cellFactory = p -> new ListCell<>() {
                 @Override
                 protected void updateItem(final ZoneId item, final boolean empty) {
                     super.updateItem(item, empty);
                     if (item != null) {
-                        setText(TimeZoneUtilities.getTimeZoneAsString(item));
+                        setText(TemporalUtilities.getTimeZoneAsString(item));
                     }
                 }
             };

CoreAttributeEditorView/test/unit/src/au/gov/asd/tac/constellation/views/attributeeditor/editors/DateTimeEditorFactoryNGTest.java

@@ -16,7 +16,7 @@
 package au.gov.asd.tac.constellation.views.attributeeditor.editors;
 
 import au.gov.asd.tac.constellation.graph.attribute.interaction.ValueValidator;
-import au.gov.asd.tac.constellation.utilities.temporal.TimeZoneUtilities;
+import au.gov.asd.tac.constellation.utilities.temporal.TemporalUtilities;
 import au.gov.asd.tac.constellation.views.attributeeditor.editors.AbstractEditorFactory.AbstractEditor;
 import au.gov.asd.tac.constellation.views.attributeeditor.editors.AbstractEditorFactory.ControlsInvalidException;
 import au.gov.asd.tac.constellation.views.attributeeditor.editors.DateTimeEditorFactory.DateTimeEditor;
@@ -110,7 +110,7 @@ public void testUpdateControlsWithValue() {
             assertEquals(editor.getMinValue(), (Integer) 0);
             assertEquals(editor.getSecValue(), (Integer) 0);
             assertEquals(editor.getMilliValue(), (Integer) 0);
-            assertEquals(editor.getTZValue(), TimeZoneUtilities.UTC);
+            assertEquals(editor.getTZValue(), TemporalUtilities.UTC);
 
             editor.updateControlsWithValue(ZonedDateTime.of(2050, 5, 5, 5, 50, 50, 5000000, ZoneId.of("GMT+2")));
 

CoreAttributeEditorView/test/unit/src/au/gov/asd/tac/constellation/views/attributeeditor/editors/TimeZoneEditorFactoryNGTest.java

@@ -16,7 +16,7 @@
 package au.gov.asd.tac.constellation.views.attributeeditor.editors;
 
 import au.gov.asd.tac.constellation.graph.attribute.interaction.ValueValidator;
-import au.gov.asd.tac.constellation.utilities.temporal.TimeZoneUtilities;
+import au.gov.asd.tac.constellation.utilities.temporal.TemporalUtilities;
 import au.gov.asd.tac.constellation.views.attributeeditor.editors.AbstractEditorFactory.AbstractEditor;
 import au.gov.asd.tac.constellation.views.attributeeditor.editors.TimeZoneEditorFactory.TimeZoneEditor;
 import java.time.ZoneId;
@@ -108,7 +108,7 @@ public void testUpdateControlsWithValue() {
         editor.createEditorControls();
 
         // default values from instantiation
-        assertEquals(editor.getValueFromControls(), TimeZoneUtilities.UTC);
+        assertEquals(editor.getValueFromControls(), TemporalUtilities.UTC);
 
         editor.updateControlsWithValue(ZoneId.of("GMT+2"));
 

CoreConversationView/src/au/gov/asd/tac/constellation/views/conversationview/DefaultConversationBackgroundProvider.java

@@ -17,7 +17,7 @@
 
 import au.gov.asd.tac.constellation.graph.GraphReadMethods;
 import au.gov.asd.tac.constellation.utilities.javafx.JavafxStyleManager;
-import au.gov.asd.tac.constellation.utilities.temporal.TimeZoneUtilities;
+import au.gov.asd.tac.constellation.utilities.temporal.TemporalUtilities;
 import java.time.ZonedDateTime;
 import java.time.temporal.ChronoField;
 import java.util.List;
@@ -40,7 +40,7 @@ public void updateMessageBackgrounds(final GraphReadMethods graph, final List<Co
 
         for (final ConversationMessage message : messages) {
             // Get the unique day since the epcoh of the date-time in UTC.
-            final int day = (int) ZonedDateTime.of(message.getDatetime().getDate().toLocalDateTime(), TimeZoneUtilities.UTC).getLong(ChronoField.EPOCH_DAY);
+            final int day = (int) ZonedDateTime.of(message.getDatetime().getDate().toLocalDateTime(), TemporalUtilities.UTC).getLong(ChronoField.EPOCH_DAY);
 
             if (day != currentDay) {
                 currentColor ^= 1;

CoreDataAccessView/src/au/gov/asd/tac/constellation/views/dataaccess/components/DataAccessTabPane.java

@@ -17,7 +17,6 @@
 
 import au.gov.asd.tac.constellation.graph.manager.GraphManager;
 import au.gov.asd.tac.constellation.plugins.parameters.PluginParameters;
-import au.gov.asd.tac.constellation.plugins.parameters.RecentParameterValues;
 import au.gov.asd.tac.constellation.plugins.parameters.types.DateTimeRange;
 import au.gov.asd.tac.constellation.utilities.text.SeparatorConstants;
 import au.gov.asd.tac.constellation.views.dataaccess.CoreGlobalParameters;

CoreDataAccessView/src/au/gov/asd/tac/constellation/views/dataaccess/panes/QueryPhasePane.java

@@ -23,7 +23,7 @@
 import au.gov.asd.tac.constellation.plugins.gui.PluginParametersPaneListener;
 import au.gov.asd.tac.constellation.plugins.parameters.PluginParameter;
 import au.gov.asd.tac.constellation.plugins.parameters.PluginParameters;
-import au.gov.asd.tac.constellation.plugins.parameters.RecentParameterValues;
+import au.gov.asd.tac.constellation.utilities.gui.recentvalue.RecentValueUtility;
 import au.gov.asd.tac.constellation.views.dataaccess.api.DataAccessPaneState;
 import au.gov.asd.tac.constellation.views.dataaccess.components.DataAccessTabPane;
 import au.gov.asd.tac.constellation.views.dataaccess.plugins.DataAccessPlugin;
@@ -406,7 +406,7 @@ public void storeParameterValues() {
                         -> param.getValue().getStringValue() != null
                 && !param.getValue().getStringValue().isEmpty()
                 )
-                .forEach(param -> RecentParameterValues.storeRecentValue(
+                .forEach(param -> RecentValueUtility.storeRecentValue(
                 param.getKey(), param.getValue().getStringValue()
         ));
 
@@ -420,12 +420,12 @@ public void storeParameterValues() {
                 .filter(param -> param.getValue().getObjectValue() != null)
                 .forEach(param -> {
                     if (!param.getValue().getType().toString().contains(DataAccessTabPane.LOCAL_DATE_PARAMETER_TYPE)) {
-                        RecentParameterValues.storeRecentValue(
+                        RecentValueUtility.storeRecentValue(
                                 param.getKey(),
                                 param.getValue().getStringValue()
                         );
                     } else {
-                        RecentParameterValues.storeRecentValue(
+                        RecentValueUtility.storeRecentValue(
                                 param.getKey(),
                                 param.getValue().getObjectValue().toString()
                         );

CoreDataAccessView/src/au/gov/asd/tac/constellation/views/dataaccess/plugins/experimental/TestParametersPlugin.java

@@ -57,6 +57,7 @@
 import au.gov.asd.tac.constellation.plugins.templates.PluginTags;
 import au.gov.asd.tac.constellation.utilities.color.ConstellationColor;
 import au.gov.asd.tac.constellation.utilities.file.FileExtensionConstants;
+import au.gov.asd.tac.constellation.utilities.gui.field.framework.ConstellationInputConstants.FileInputKind;
 import au.gov.asd.tac.constellation.utilities.text.SpellCheckingTextArea;
 import au.gov.asd.tac.constellation.views.dataaccess.CoreGlobalParameters;
 import au.gov.asd.tac.constellation.views.dataaccess.plugins.DataAccessPlugin;
@@ -83,12 +84,7 @@
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import javafx.scene.control.CheckBox;
-import javafx.scene.control.ComboBox;
-import javafx.scene.control.ListCell;
-import javafx.scene.control.ListView;
 import javafx.scene.image.Image;
-import javafx.scene.image.ImageView;
-import javafx.scene.paint.Color;
 import javafx.stage.FileChooser.ExtensionFilter;
 import org.netbeans.api.annotations.common.StaticResource;
 import org.openide.util.NbBundle.Messages;
@@ -272,14 +268,14 @@ public PluginParameters createParameters() {
         final PluginParameter<FileParameterValue> openFileParam = FileParameterType.build(INPUT_FILE_PARAMETER_ID);
         openFileParam.setName("Input file");
         openFileParam.setDescription("A file to read stuff from");
-        FileParameterType.setKind(openFileParam, FileParameterType.FileParameterKind.OPEN);
+        FileParameterType.setKind(openFileParam, FileInputKind.OPEN);
         FileParameterType.enableAcceptAllFileFilter(openFileParam);
         params.addParameter(openFileParam);
 
         final PluginParameter<FileParameterValue> saveFileParam = FileParameterType.build(OUTPUT_FILE_PARAMETER_ID);
         saveFileParam.setName("Output file");
         saveFileParam.setDescription("A file to write stuff to");
-        FileParameterType.setKind(saveFileParam, FileParameterType.FileParameterKind.SAVE);
+        FileParameterType.setKind(saveFileParam, FileInputKind.SAVE);
         FileParameterType.setFileFilters(saveFileParam, new ExtensionFilter("Text files", FileExtensionConstants.TEXT));
         params.addParameter(saveFileParam);
 

CoreDataAccessView/test/unit/src/au/gov/asd/tac/constellation/views/dataaccess/components/DataAccessTabPaneNGTest.java

@@ -19,10 +19,10 @@
 import au.gov.asd.tac.constellation.graph.manager.GraphManager;
 import au.gov.asd.tac.constellation.plugins.parameters.PluginParameter;
 import au.gov.asd.tac.constellation.plugins.parameters.PluginParameters;
-import au.gov.asd.tac.constellation.plugins.parameters.RecentParameterValues;
 import au.gov.asd.tac.constellation.plugins.parameters.types.BooleanParameterType;
 import au.gov.asd.tac.constellation.plugins.parameters.types.DateTimeRange;
 import au.gov.asd.tac.constellation.plugins.parameters.types.LocalDateParameterType;
+import au.gov.asd.tac.constellation.utilities.gui.recentvalue.RecentValueUtility;
 import au.gov.asd.tac.constellation.views.dataaccess.DataAccessViewTopComponent;
 import au.gov.asd.tac.constellation.views.dataaccess.api.DataAccessPaneState;
 import au.gov.asd.tac.constellation.views.dataaccess.panes.DataAccessPane;
@@ -372,12 +372,12 @@ public void storeParameterValues_verify_global_params_stored() {
         when(pluginParameter3.getStringValue()).thenReturn("PluginParam3 String Value");
 
         try (
-                final MockedStatic<RecentParameterValues> recentParamValsMockedStatic
-                = Mockito.mockStatic(RecentParameterValues.class);) {
+                final MockedStatic<RecentValueUtility> recentParamValsMockedStatic
+                = Mockito.mockStatic(RecentValueUtility.class);) {
             dataAccessTabPane.storeParameterValues();
 
             // Verify that only plugin 3 parameter was set in the store
-            recentParamValsMockedStatic.verify(() -> RecentParameterValues
+            recentParamValsMockedStatic.verify(() -> RecentValueUtility
                     .storeRecentValue("plugin3", "PluginParam3 String Value"));
         }
     }
@@ -456,14 +456,15 @@ public void storeParameterValues_verify_plugin_params_stored() {
         when(pluginParameter3.getStringValue()).thenReturn("PluginParam3 String Value");
 
         try (
-                final MockedStatic<RecentParameterValues> recentParamValsMockedStatic
-                = Mockito.mockStatic(RecentParameterValues.class);) {
+                final MockedStatic<RecentValueUtility> recentParamValsMockedStatic =
+                        Mockito.mockStatic(RecentValueUtility.class);
+        ) {
             dataAccessTabPane.storeParameterValues();
 
             // Verify that parameters for plugins 2 and 3 were set to the store correctly
-            recentParamValsMockedStatic.verify(() -> RecentParameterValues
+            recentParamValsMockedStatic.verify(() -> RecentValueUtility
                     .storeRecentValue("plugin2", "PluginParam2 Object Value"));
-            recentParamValsMockedStatic.verify(() -> RecentParameterValues
+            recentParamValsMockedStatic.verify(() -> RecentValueUtility
                     .storeRecentValue("plugin3", "PluginParam3 String Value"));
         }
     }

CoreFindView/src/au/gov/asd/tac/constellation/views/find/components/advanced/DateTimeCriteriaPanel.java

@@ -17,7 +17,7 @@
 
 import au.gov.asd.tac.constellation.graph.GraphElementType;
 import au.gov.asd.tac.constellation.graph.attribute.ZonedDateTimeAttributeDescription;
-import au.gov.asd.tac.constellation.utilities.temporal.TimeZoneUtilities;
+import au.gov.asd.tac.constellation.utilities.temporal.TemporalUtilities;
 import au.gov.asd.tac.constellation.views.find.components.AdvancedFindTab;
 import au.gov.asd.tac.constellation.views.find.components.advanced.criteriavalues.DateTimeCriteriaValues;
 import au.gov.asd.tac.constellation.views.find.components.advanced.criteriavalues.FindCriteriaValues;
@@ -236,15 +236,15 @@ private void timeFrameSelectionAction(final String choiceSelection) {
             // and the previously selected timeZone
             dateStringTwo = LocalDate.now().toString();
             timeStringTwo = "23:59:59.999";
-            timeZoneStringTwo = (StringUtils.isEmpty(timeZoneString) ? TimeZoneUtilities.getTimeZoneAsString(TimeZoneUtilities.UTC) : TimeZoneUtilities.getTimeZoneAsString(ZoneId.of(formattedTimeZoneString)));
+            timeZoneStringTwo = (StringUtils.isEmpty(timeZoneString) ? TemporalUtilities.getTimeZoneAsString(TemporalUtilities.UTC) : TemporalUtilities.getTimeZoneAsString(ZoneId.of(formattedTimeZoneString)));
 
             // set dateTime one data to the min time of today
             // and the previously selected timeZone
             timeString = "00:00:00.000";
-            timeZoneString = (StringUtils.isEmpty(timeZoneString) ? TimeZoneUtilities.getTimeZoneAsString(TimeZoneUtilities.UTC) : TimeZoneUtilities.getTimeZoneAsString(ZoneId.of(formattedTimeZoneString)));
+            timeZoneString = (StringUtils.isEmpty(timeZoneString) ? TemporalUtilities.getTimeZoneAsString(TemporalUtilities.UTC) : TemporalUtilities.getTimeZoneAsString(ZoneId.of(formattedTimeZoneString)));
 
             // The Local Date value of the current date based of the timeZone
-            final LocalDate calculatedDate = LocalDate.now(StringUtils.isEmpty(dateString) ? TimeZoneUtilities.UTC : ZoneId.of(formattedTimeZoneString));
+            final LocalDate calculatedDate = LocalDate.now(dateString.equals("") ? TemporalUtilities.UTC : ZoneId.of(formattedTimeZoneString));
 
             // Switch statment that determines the date string one value based
             // off the choiceSelection