Skip to content

[WIP] VXEdDSA#167

Open
liamsi wants to merge 6 commits into
masterfrom
vxeddsa
Open

[WIP] VXEdDSA#167
liamsi wants to merge 6 commits into
masterfrom
vxeddsa

Conversation

@liamsi
Copy link
Copy Markdown
Member

@liamsi liamsi commented Feb 5, 2017 •
edited
Loading

resolves #128
working version; still needs some cleanup:

  • use cached public-key
  • cleanup ed25519 package (unexport funcs, keep only one elligator2 implementation, test-vectors for elligator)
  • adopt to google's keytransparency vrf interface (?)
  • asserts
  • increase code readability (and make it more golang idiomatic)
  • TODOs, XXXs

@liamsi liamsi force-pushed the vxeddsa branch 3 times, most recently from 5dd17d8 to 509c439 Compare February 5, 2017 21:44
@liamsi
[WIP] First working version (passes all VXEdDSA test-vectors); still …
08ba3d1 
…needs some cleanup:

- [ ] increase code readability (and more golang idiomatic)
- [ ] use cached public-key
- [ ] cleanup ed25519 package (unexport funcs, keep only one elligator2 implementation, test-vectors for elligator)
- [ ] adopt to google's keytransparency vrf interface (?)
- [ ] asserts
- [ ] TODOs, XXXs
@liamsi liamsi force-pushed the vxeddsa branch 2 times, most recently from 3813426 to 95a8fd1 Compare February 5, 2017 22:07
vqhuy
vqhuy reviewed Mar 2, 2017
View reviewed changes
Comment thread crypto/vrf/vrf.go
ErrGetPubKey = errors.New("[vrf] Couldn't get corresponding public-key from private-key")
)
// PrivateKey represents a Curve25519 private key.
type PrivateKey [PrivateKeySize]byte
Copy link
Copy Markdown
Member

@vqhuy vqhuy Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep using the old bytes slice type PrivateKey []byte instead?

Copy link
Copy Markdown
Member Author

@liamsi liamsi Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks. It makes sense to keep independent from the actual implementation/key-size used.

Copy link
Copy Markdown
Member

@vqhuy vqhuy Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Copy link
Copy Markdown
Member Author

@liamsi liamsi Mar 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the long run (or maybe even in this pull?) we should switch to using an interface which completely hides the underlying representation (similar to this: https://github.com/google/keytransparency/blob/master/core/vrf/vrf.go)

Copy link
Copy Markdown
Member

@vqhuy vqhuy Mar 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the signer. It is tracked in #50.

@vqhuy vqhuy added this to the 0.2.0 milestone Apr 12, 2017
@liamsi liamsi mentioned this pull request May 25, 2017
Merged
@masomel masomel modified the milestones: 0.2.0, VRF change Aug 3, 2017
@aarshkshah1992
Copy link
Copy Markdown

aarshkshah1992 commented Dec 24, 2018

Hey guys,

This looks like great work. Any plans to merge this ?

@vqhuy
Copy link
Copy Markdown
Member

vqhuy commented Dec 25, 2018

Hi, I'm afraid that we don't have any plan to merge this soon. In the meantime, you can merge it on your own fork if you want ;)

@aarshkshah1992
Copy link
Copy Markdown

aarshkshah1992 commented Dec 26, 2018

Thanks vqhuy. May I ask why there are no plans to merge this ? Do you need a developer to help clean this up before it is merged ?

@vqhuy
Copy link
Copy Markdown
Member

vqhuy commented Dec 26, 2018

Do you need a developer to help clean this up before it is merged ?

Yes, you are more than welcome. You might want to take a look at this list, especially the VRF interface.

/cc @liamsi.

@aarshkshah1992
Copy link
Copy Markdown

aarshkshah1992 commented Dec 28, 2018

@liamsi Thanks for the awesome work. I'd like to take this forward. Please can you elaborate a bit on these points of your checklist

  1. Use cached Public key
  2. Asserts

Also, would you be willing to review this once it is done ?

@liamsi
Copy link
Copy Markdown
Member Author

liamsi commented Jan 2, 2019

@liamsi Thanks for the awesome work. I'd like to take this forward. Please can you elaborate a bit on these points of your checklist

Unfortunately, I do not remember off the top of my head what those points on the checklist mean in detail. I'd need to look into the code (this implementation and the whispersystem C code) to understand what I was planning 🙈

Also, would you be willing to review this once it is done ?

Yes, of course! I'd be happy to review this!

@Swivelgames Swivelgames mentioned this pull request Jul 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vqhuy vqhuy vqhuy left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

VRF change

Development

Successfully merging this pull request may close these issues.

Switch to VXEdDSA

4 participants

@liamsi @aarshkshah1992 @vqhuy @masomel