Skip to content

Role-binding flag text, linter bool-flag exception, logout no-op. #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
David Adams (davidadas) wants to merge 5 commits into from
Closed

Role-binding flag text, linter bool-flag exception, logout no-op. #3421

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c01cb3f
[APIE-1362] Fix misleading --inclusive flag description on role-bindi…
davidadas Jul 30, 2026
8eb99e2
[APIE-1286] Allow boolean flags to use "=" in examples without failin…
davidadas Jul 30, 2026
bca05bc
[APIE-1314] `confluent logout` should be a no-op when already logged out
davidadas Jul 30, 2026
e627081
Address Copilot review comment on PR #3421 (APIE-1362)
davidadas Jul 30, 2026
f396d3f
Fix nil pointer panic in logout when Version is unset (APIE-1314)
davidadas Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/iam/command_rbac_role_binding_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ func (c *roleBindingCommand) newListCommand() *cobra.Command {
}

cmd.Flags().String("resource", "", `Resource type and identifier using "Prefix:ID" format. If specified with "--role" and no principals, list all principals and role bindings.`)
cmd.Flags().Bool("inclusive", false, "List role bindings for specified scopes and nested scopes. Otherwise, list role bindings for the specified scopes. If scopes are unspecified, list only organization-scoped role bindings.")
cmd.Flags().Bool("inclusive", false, "List role bindings for specified scopes and nested scopes. Otherwise, list role bindings for the specified scopes. If scopes are unspecified, list role bindings across all scopes.")
Comment thread
davidadas marked this conversation as resolved.
Outdated
pcmd.AddOutputFlag(cmd)

return cmd
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/iam/rbac/role-binding/list-failure-help-cloud.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Flags:
--ksql-cluster string ksqlDB cluster name, which specifies the ksqlDB cluster scope.
--flink-region string Flink region for the role binding, formatted as "cloud.region".
--resource string Resource type and identifier using "Prefix:ID" format. If specified with "--role" and no principals, list all principals and role bindings.
--inclusive List role bindings for specified scopes and nested scopes. Otherwise, list role bindings for the specified scopes. If scopes are unspecified, list only organization-scoped role bindings.
--inclusive List role bindings for specified scopes and nested scopes. Otherwise, list role bindings for the specified scopes. If scopes are unspecified, list role bindings across all scopes.
Comment thread
davidadas marked this conversation as resolved.
Outdated
-o, --output string Specify the output format as "human", "json", or "yaml". (default "human")

Global Flags:
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/iam/rbac/role-binding/list-failure-help-onprem.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Flags:
--context string CLI context name.
--cluster-name string Cluster name, which specifies the cluster scope.
--resource string Resource type and identifier using "Prefix:ID" format. If specified with "--role" and no principals, list all principals and role bindings.
--inclusive List role bindings for specified scopes and nested scopes. Otherwise, list role bindings for the specified scopes. If scopes are unspecified, list only organization-scoped role bindings.
--inclusive List role bindings for specified scopes and nested scopes. Otherwise, list role bindings for the specified scopes. If scopes are unspecified, list role bindings across all scopes.
Comment thread
davidadas marked this conversation as resolved.
Outdated
-o, --output string Specify the output format as "human", "json", or "yaml". (default "human")

Global Flags:
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/iam/rbac/role-binding/list-help-onprem.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Flags:
--context string CLI context name.
--cluster-name string Cluster name, which specifies the cluster scope.
--resource string Resource type and identifier using "Prefix:ID" format. If specified with "--role" and no principals, list all principals and role bindings.
--inclusive List role bindings for specified scopes and nested scopes. Otherwise, list role bindings for the specified scopes. If scopes are unspecified, list only organization-scoped role bindings.
--inclusive List role bindings for specified scopes and nested scopes. Otherwise, list role bindings for the specified scopes. If scopes are unspecified, list role bindings across all scopes.
Comment thread
davidadas marked this conversation as resolved.
Outdated
-o, --output string Specify the output format as "human", "json", or "yaml". (default "human")

Global Flags:
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/iam/rbac/role-binding/list-help.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Flags:
--ksql-cluster string ksqlDB cluster name, which specifies the ksqlDB cluster scope.
--flink-region string Flink region for the role binding, formatted as "cloud.region".
--resource string Resource type and identifier using "Prefix:ID" format. If specified with "--role" and no principals, list all principals and role bindings.
--inclusive List role bindings for specified scopes and nested scopes. Otherwise, list role bindings for the specified scopes. If scopes are unspecified, list only organization-scoped role bindings.
--inclusive List role bindings for specified scopes and nested scopes. Otherwise, list role bindings for the specified scopes. If scopes are unspecified, list role bindings across all scopes.
Comment thread
davidadas marked this conversation as resolved.
Outdated
-o, --output string Specify the output format as "human", "json", or "yaml". (default "human")

Global Flags:
Expand Down