Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/veritas/platforms/baremetal.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class BaremetalExtractor(PlatformExtractor):
EDK2_RPM_GLOB = "edk2-ovmf-*.rpm"
EXTENSIONS_PATH = "/usr/share/rpm-ostree/extensions"
INITRD_GLOB = "osbuilder-images/*/kata-cc.initrd"
GPU_INITRD_GLOB = "osbuilder-images/*/kata-*gpu*.initrd"
GPU_INITRD_GLOB = "osbuilder-images/*/kata-cc-*gpu*.initrd"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pezhang thanks for the PR number 1 !! :)

I'm just curious why the previous line didn't catch your initrd. Do you see how the line you are removing is broader?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @beraldoleal , in the below codes from https://github.com/confidential-devhub/veritas/blob/main/src/veritas/platforms/baremetal.py, seems the artifacts["gpu_initrd"] has only read the 1st item.

            # Detect GPU initrd
            gpu_initrd_candidates = list(extract_path.rglob(self.GPU_INITRD_GLOB))
            if gpu_initrd_candidates:
                artifacts["gpu_initrd"] = gpu_initrd_candidates[0]
                log.info("Found GPU initrd: %s", artifacts["gpu_initrd"])

So we only get 1 GPU initrd without this PR:
INFO: Found GPU initrd: /tmp/tmpbgui7v60/usr/share/kata-containers/osbuilder-images/6.12.0-124.21.1.el10_1.x86_64/kata-nvidia-gpu-580.105.08.initrd


OCP_RELEASE_REPO = "quay.io/openshift-release-dev/ocp-release"

Expand Down