Fix missing context import in query.py#128
Merged
Merged
Conversation
The permanent packages setting merged in #116 references `context.plugins.self_permanent_packages` without importing `context`, causing ruff F821 and mypy name-defined errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the pre-commit failure on main introduced by #116.
The PR branch was based on an older
query.pythat already hadfrom conda.base.context import context(needed bycheck_updates/latest). Between the merge base and main, those functions were moved elsewhere, removing the import. The PR's diff only touched theprotectline, so the squash merge applied cleanly against main's slimmed-downquery.pywithout a conflict, but silently dropped the import the new code depends on.Changes
from conda.base.context import contexttoconda_self/query.pyTest plan
pre-commit run --all-filespasses (ruff F821, mypyname-defined)