Add kalign and kalign-python#32505
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/kalign/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/22816598332. Examine the logs at this URL for more detail. |
|
Hi! This is the staged-recipes linter and your PR looks excellent but I have some suggestions. File-specific lints and/or hints:
|
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/kalign/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/22816770208. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/kalign/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/22817176881. Examine the logs at this URL for more detail. |
|
We have in bioconda a package called kalign2 and kalign3. This might cause confusion to users I think. Is it the same tool? |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Good question @bgruening. Yes, it is the same tool: kalign3 is "kalign version 3". See answer in PR description. |
|
@sdvillal have you seen my comment above? |
Could you please read my answer in the PR description and tell me what do you think? Without migrating this one package to conda-forge we will not be able to have conda-forge packages for openfold-3 (and other related ML models). But if we decide to keep it in bioconda, happy if the work in this PR maybe helps bringing the new features there. |
|
I will ping a few people and ask. Naming it |
|
That would be much appreciated. My plan was to figure bioconda's package contributors by looking at git history, which likely is not the best way to go. Once we decide, let's ping kalign's author to see if he also would like to become a maintainer and to suggest adding the conda package to the docs. |
|
@bgruening should I try helping contacting the bioconda maintainers? I do not know how to find the right list of people, as bioconda recipes are not organized in repos. Should I just open an issue there and ping recent committers? This is blocking using kalign-python in conda environments in osx due to this problem with the wheels (see also this). This is also blocking openfold-3 having a working conda environment and package creation after the recent 0.4 release. For reference, this is the autobump PR in bioconda. |
Consistent use of quotes
|
@bgruening it is not clear to me who is actively maintaining kalign3 in bioconda. The automated PR fails and has not received any attention so far. What is the mechanism to deprecate a package in bioconda? I would just open an issue in the recipes repo. As a note, the only package that depends on kalign3 is kcalign. Migration would mean swapping kalign3 to kalign in its recipe. Really appreciate your help :-) |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/kalign/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/23944716858. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/help-c-cpp @conda-forge/help-python ready to review If/when merged:
|
|
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
|
@Emrys-Merlin can you please confirm your availability as maintainer? |
|
Yes, I'd be happy to contribute as a maintainer here. |
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
fyi @conda-forge/bioconda-recipes is the plan proposed in this PR ok for you? |
@traversaro thanks for giving it a look @conda-forge/bioconda-recipes hearing your feedback would be great 👍 |
|
@traversaro it feels bioconda maintainers do not have bandwidth, fully understandable. To unblock other dependent work, an option would be to finish and merge this and then opening a PR in bioconda to deprecate the kalign3 recipe there. I think we might get more space for discussion if needed this way. This might already be right as per this comment from @bgruening
I think the reasoning for migration is sound, the new kalign-python output important, and I believe we are managing to have 100% seamless transition also for bioconda dependants (only one package) and final users. Alternatively, we could open a new PR only with kalign-python, which does not exist yet in bioconda - likely suboptimal. Sorry for asking for non-technical advice. |
|
This patch might be needed when we enable arm builds |
|
@traversaro @conda-forge/bioconda-recipes it would be really useful if we could unblock this recipe, any help is highly appreciated |
|
Sorry, if @conda-forge/bioconda-recipes people are not responsive I am not sure how to proceed. You may try to escalate this to @conda-forge/core, but I am not sure if any of core members have a better solution. |
|
Thanks, this looks good to me. Sorry, I needed to filter conda-forge email notifications, they are just too much. |
|
Thank a lot @bgruening ! |
|
Thank you both! Exciting :-) |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).kalignconda-forge recipe proposal; big thanks to the authors of the original bioconda recipe.This one would:
From this comment:
Good question @bgruening. Yes, it is the same tool: kalign3 is "kalign version 3".
The plan was to get first this working and then figure if:
kalign3recipe (plus creating a new recipe or outputkalign-python)kalign-pythonin conda-forge (which would not collide with anything in bioconda and enable our downstream packaging needs), and let the biocondakalign3package continue as isContext
We are hoping to publish soon an openfold3 package targeting conda-forge (as we hope for openfold-3 to also become an easier building block for other programs), which will require good CUDA/GPU support and cross-platform abilities in the building infrastructure (e.g., for getting bot migrations, for building and testing CUDA extensions).
kalignhas now python bindings, also published as wheels (see 1, 2). It also changed its license from GPL to Apache, so that it could play well with openfold3.Channel: Bioconda or conda-forge?
For me, it is much preferred to port to conda-forge and not maintain anymore kalign3 in bioconda, hopefully bringing any interested active bioconda maintainers along. The upcoming version of openfold3 depends on kalign-python, so if we only have it in bioconda, it will be a blocker (the only one remaining at the moment).
People looking for the new version in the conda ecosystem will for sure be able to use the conda-forge package, and we could add a synonymous output "kalign3" to the recipe, making transition seamless (since anyway people using bioconda should also be using conda-forge).
Name: "kalign3" or "kalign"
I believe renaming to
kalignis the better way, as it is:kalign-python)As written before, we could still keep a synonymous package "kalign3" to not break any user's workflow.