Skip to content

Ferre-2012-380#1527

Merged
MiraAhmedovic merged 8 commits into
masterfrom
Ferre-2012-380
Jun 17, 2026
Merged

Ferre-2012-380#1527
MiraAhmedovic merged 8 commits into
masterfrom
Ferre-2012-380

Conversation

@MiraAhmedovic

Copy link
Copy Markdown
Collaborator

Pull request checklist

  • add new concept list
  • add new metadata
  • add new Concepticon concept sets
    • checked whether the new concept(s) can be applied to existing lists with
      concepticon notlinked --gloss "NEW_GLOSS"
  • add new Concepticon concept relations
  • refine existing Concepticon concept set mappings
  • refine Concepticon glosses
  • refine Concepticon concept relations
  • refine Concepticon concept definitions
  • retire data

Additional information

Adding Ferre-2012-380 based on Ferré et al. (2012) Affective norms for 380 Spanish words belonging to three different semantic categories. There was no English translation for the items so I used DeepL to map the concepts. Therefore, it might make sense to have a native speaker/person with good intuition for Spanish check the mappings in this PR.
Closes issue #1523.

@MiraAhmedovic

Copy link
Copy Markdown
Collaborator Author

@AnnikaTjuka, would you moderate this PR?

@AnnikaTjuka

Copy link
Copy Markdown
Collaborator

Sure, @FredericBlum or @CMUgarte Would you have time to review the PR?

@CMUgarte

CMUgarte commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

I can do it later in the day, @AnnikaTjuka and @MiraAhmedovic. It's been a while since I've reviewed the addition of a concept list.

@AnnikaTjuka

Copy link
Copy Markdown
Collaborator

Thanks! Let us know if you have any questions while reviewing the list.

@FredericBlum FredericBlum left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my review. There are a couple of cases which we should probably discuss, as well as one or two instances where adding a new concept might be warranted.

Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv Outdated
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv Outdated
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv Outdated
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv Outdated
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv Outdated
Comment thread concepticondata/references/references.bib

@CMUgarte CMUgarte left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnnikaTjuka I finished my review. Most of them are cases for concept additions to Concepticon. So perhaps not all of them are important or pertinent for this PR. Thanks, @MiraAhmedovic, for the great work!

Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv Outdated
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv Outdated
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv Outdated
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
@MiraAhmedovic

Copy link
Copy Markdown
Collaborator Author

Thank you so much for the thorough feedback @CMUgarte and @FredericBlum! I've now implemented what I think is the first round of changes. @AnnikaTjuka, could you have a look at the comments that were left unresolved and give your two cents?
I think there were a lot of reasonable suggestions for new concepts. Unfortunately, not all of them have a lot of mappings yet, so only a few of them might be added at this time. The ones we can settle on, I'll add in a separate PR so this doesn't get too messy.

@AnnikaTjuka AnnikaTjuka left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left comments on the open discussions. @CMUgarte and @FredericBlum Could you please check if your comments have been addressed and approve the PR if applicable?

Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv Outdated
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv Outdated
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
Comment thread concepticondata/conceptlists/Ferre-2012-380.tsv
@MiraAhmedovic

Copy link
Copy Markdown
Collaborator Author

Thank you for going over everything again @AnnikaTjuka! I think round two is done from my end, so feel free to check @FredericBlum and @CMUgarte !

@CMUgarte

CMUgarte commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

All my comments have been addressed and it is clear to me now that we wait at least 6 appearances to propose a new concept, @AnnikaTjuka and @MiraAhmedovic. I guess the new addtions come in other PRs, so, from my side, we can merge this one. Thanks, Mira, for the work on this!

@MiraAhmedovic

Copy link
Copy Markdown
Collaborator Author

I've added the CAIMAN-ALLIGATOR relation to conceptrelations.tsv. @FredericBlum, in case we're all done here, could you approve the changes? :)

@FredericBlum FredericBlum left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see this was still pending!

@MiraAhmedovic

Copy link
Copy Markdown
Collaborator Author

No worries at all @FredericBlum! After your final check @AnnikaTjuka, I'm ready to merge.

@AnnikaTjuka AnnikaTjuka left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, everyone! Looks good.

@MiraAhmedovic MiraAhmedovic merged commit 60efd2e into master Jun 17, 2026
1 check passed
@MiraAhmedovic MiraAhmedovic deleted the Ferre-2012-380 branch June 17, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants