Ferre-2012-380#1527
Conversation
|
@AnnikaTjuka, would you moderate this PR? |
|
Sure, @FredericBlum or @CMUgarte Would you have time to review the PR? |
|
I can do it later in the day, @AnnikaTjuka and @MiraAhmedovic. It's been a while since I've reviewed the addition of a concept list. |
|
Thanks! Let us know if you have any questions while reviewing the list. |
FredericBlum
left a comment
There was a problem hiding this comment.
Here is my review. There are a couple of cases which we should probably discuss, as well as one or two instances where adding a new concept might be warranted.
There was a problem hiding this comment.
@AnnikaTjuka I finished my review. Most of them are cases for concept additions to Concepticon. So perhaps not all of them are important or pertinent for this PR. Thanks, @MiraAhmedovic, for the great work!
|
Thank you so much for the thorough feedback @CMUgarte and @FredericBlum! I've now implemented what I think is the first round of changes. @AnnikaTjuka, could you have a look at the comments that were left unresolved and give your two cents? |
AnnikaTjuka
left a comment
There was a problem hiding this comment.
I left comments on the open discussions. @CMUgarte and @FredericBlum Could you please check if your comments have been addressed and approve the PR if applicable?
|
Thank you for going over everything again @AnnikaTjuka! I think round two is done from my end, so feel free to check @FredericBlum and @CMUgarte ! |
|
All my comments have been addressed and it is clear to me now that we wait at least 6 appearances to propose a new concept, @AnnikaTjuka and @MiraAhmedovic. I guess the new addtions come in other PRs, so, from my side, we can merge this one. Thanks, Mira, for the work on this! |
|
I've added the CAIMAN-ALLIGATOR relation to |
FredericBlum
left a comment
There was a problem hiding this comment.
Sorry, I didn't see this was still pending!
|
No worries at all @FredericBlum! After your final check @AnnikaTjuka, I'm ready to merge. |
AnnikaTjuka
left a comment
There was a problem hiding this comment.
Many thanks, everyone! Looks good.
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"Additional information
Adding Ferre-2012-380 based on Ferré et al. (2012) Affective norms for 380 Spanish words belonging to three different semantic categories. There was no English translation for the items so I used DeepL to map the concepts. Therefore, it might make sense to have a native speaker/person with good intuition for Spanish check the mappings in this PR.
Closes issue #1523.