Fix: Resolve inherited members through implicit UsingShadowDecls by Krishna-13-cyber · Pull Request #1038 · compiler-research/CppInterOp

Krishna-13-cyber · 2026-06-19T07:35:40Z

Description

Please include a summary of changes, motivation and context for this PR.
Member lookup considered declarations could miss members inherited from base classes in some record lookup contexts.

The change adds a fallback to unqualified lookup when direct record lookup fails. This allows lookup to traverse base classes and find inherited members. When an inherited member is found, an implicit UsingShadowDecl is created in the derived class to represent that inherited member as if it were introduced into the derived class scope
UsingShadowDecl mechanism should handle inherited typedefs as well.

Fixes # (issue)
#93 fixes this issue.

Type of change

Please tick all options which are relevant.

[ X ] Bug fix
New feature
Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.
https://github.com/compiler-research/CppInterOp/pull/123/changes
this is the reproducible test, which gets passed after this patch.

Checklist

I have read the contribution guide recently

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 19. Check the log or trigger a new build to see more.

github-actions · 2026-06-19T07:45:11Z

 }

+
+static clang::UsingShadowDecl *CreateInheritedUsingShadow(


warning: 'CreateInheritedUsingShadow' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]

Suggested change

static clang::UsingShadowDecl *CreateInheritedUsingShadow(

;

github-actions · 2026-06-19T07:45:11Z

+        }
+      }
+      if (FoundND)
+        return INTEROP_RETURN((TCppScope_t)(FoundND->getCanonicalDecl()));


warning: use of undeclared identifier 'TCppScope_t' [clang-diagnostic-error]

ndND) ^

github-actions · 2026-06-19T07:45:11Z

+      // record contexts. Use unqualified lookup from a synthesized point
+      // inside the class to traverse base classes and find the member.
+      auto* ND2 = LookupUnqualified(getSema(), DName, Within);
+      if (ND2 && ND2 != (clang::NamedDecl*)-1) {


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

hin); ^

github-actions · 2026-06-19T07:45:11Z

+      // record contexts. Use unqualified lookup from a synthesized point
+      // inside the class to traverse base classes and find the member.
+      auto* ND2 = LookupUnqualified(getSema(), DName, Within);
+      if (ND2 && ND2 != (clang::NamedDecl*)-1) {


warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr]

hin); ^

github-actions · 2026-06-19T07:45:11Z

+      auto* ND2 = LookupUnqualified(getSema(), DName, Within);
+      if (ND2 && ND2 != (clang::NamedDecl*)-1) {
+        if (auto* Shadow = CreateInheritedUsingShadow(RD, ND2))
+          return INTEROP_RETURN((TCppScope_t)(Shadow->getCanonicalDecl()));


warning: use of undeclared identifier 'TCppScope_t' [clang-diagnostic-error]

ND2)) ^

github-actions · 2026-06-19T07:45:11Z

+      if (ND2 && ND2 != (clang::NamedDecl*)-1) {
+        if (auto* Shadow = CreateInheritedUsingShadow(RD, ND2))
+          return INTEROP_RETURN((TCppScope_t)(Shadow->getCanonicalDecl()));
+        return INTEROP_RETURN((TCppScope_t)(ND2->getCanonicalDecl()));


warning: use of undeclared identifier 'TCppScope_t' [clang-diagnostic-error]

())); ^

github-actions · 2026-06-19T07:45:11Z

+          return INTEROP_RETURN((TCppScope_t)(Shadow->getCanonicalDecl()));
+        return INTEROP_RETURN((TCppScope_t)(ND2->getCanonicalDecl()));
+      }
+      if (ND2 == (clang::NamedDecl*)-1)


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

} ^

github-actions · 2026-06-19T07:45:11Z

+          return INTEROP_RETURN((TCppScope_t)(Shadow->getCanonicalDecl()));
+        return INTEROP_RETURN((TCppScope_t)(ND2->getCanonicalDecl()));
+      }
+      if (ND2 == (clang::NamedDecl*)-1)


warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr]

} ^

github-actions · 2026-06-19T07:45:11Z

+    };
+  )");
+
+Cpp::TCppScope_t strt_S = Cpp::GetNamed("S", nullptr);


warning: no type named 'TCppScope_t' in namespace 'Cpp' [clang-diagnostic-error]

Cpp::TCppScope_t strt_S = Cpp::GetNamed("S", nullptr); ^

github-actions · 2026-06-19T07:45:11Z

+  )");
+
+Cpp::TCppScope_t strt_S = Cpp::GetNamed("S", nullptr);
+Cpp::TCppScope_t strt_S_Val = Cpp::GetNamed("Val", strt_S);


warning: no type named 'TCppScope_t' in namespace 'Cpp' [clang-diagnostic-error]

Cpp::TCppScope_t strt_S_Val = Cpp::GetNamed("Val", strt_S); ^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 16. Check the log or trigger a new build to see more.

github-actions · 2026-06-27T14:12:04Z

+
+  clang::ASTContext &C = Record->getASTContext();
+  clang::DeclarationNameInfo NameInfo(Target->getDeclName(),
+                                      clang::SourceLocation());


warning: use nullptr [modernize-use-nullptr]

Suggested change

clang::SourceLocation());

= nullptr;

github-actions · 2026-06-27T14:12:04Z

+  Record->addDecl(Shadow);
+
+  return Shadow;
+}


warning: no header providing "CppInternal::utils::Lookup::Named" is directly included [misc-include-cleaner]

lib/CppInterOp/CppInterOp.cpp:10:

- #include "Unwrap.h" + #include "CppInterOpInterpreter.h" + #include "Unwrap.h"

github-actions · 2026-06-27T14:12:04Z

+
+  return Shadow;
+}
+


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

hin); ^

github-actions · 2026-06-27T14:12:04Z

+
+  return Shadow;
+}
+


warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr]

hin); ^

github-actions · 2026-06-27T14:12:04Z

+    if (auto* RD = llvm::dyn_cast<clang::CXXRecordDecl>(Within)) {
+      clang::DeclarationName DName = &getSema().Context.Idents.get(name);
+      auto Decls = RD->lookup(DName);
+      clang::NamedDecl* FoundND = nullptr;


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

hin); ^

github-actions · 2026-06-27T14:12:04Z

+    if (auto* RD = llvm::dyn_cast<clang::CXXRecordDecl>(Within)) {
+      clang::DeclarationName DName = &getSema().Context.Idents.get(name);
+      auto Decls = RD->lookup(DName);
+      clang::NamedDecl* FoundND = nullptr;


warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr]

hin); ^

github-actions · 2026-06-27T14:12:04Z

+      }
+      if (FoundND)
+        return INTEROP_RETURN((FoundND->getCanonicalDecl()));
+


warning: do not use const_cast to remove const qualifier [cppcoreguidelines-pro-type-const-cast]

DRef. ^

github-actions · 2026-06-27T14:12:04Z

+
+Cpp::TCppScope_t strt_S = Cpp::GetNamed("S", nullptr);
+Cpp::TCppScope_t strt_S_Val = Cpp::GetNamed("Val", strt_S);
+Cpp::TCppScope_t strt_S1 = Cpp::GetNamed("S1", nullptr);


warning: expected ';' after expression [clang-diagnostic-error]

Suggested change

Cpp::TCppScope_t strt_S1 = Cpp::GetNamed("S1", nullptr);

Cpp::TCppScope_t; strt_S1 = Cpp::GetNamed("S1", nullptr);

github-actions · 2026-06-27T14:12:04Z

+
+Cpp::TCppScope_t strt_S = Cpp::GetNamed("S", nullptr);
+Cpp::TCppScope_t strt_S_Val = Cpp::GetNamed("Val", strt_S);
+Cpp::TCppScope_t strt_S1 = Cpp::GetNamed("S1", nullptr);


warning: no member named 'TCppScope_t' in namespace 'Cpp' [clang-diagnostic-error]

Cpp::TCppScope_t strt_S1 = Cpp::GetNamed("S1", nullptr); ^

github-actions · 2026-06-27T14:12:04Z

+
+Cpp::TCppScope_t strt_S = Cpp::GetNamed("S", nullptr);
+Cpp::TCppScope_t strt_S_Val = Cpp::GetNamed("Val", strt_S);
+Cpp::TCppScope_t strt_S1 = Cpp::GetNamed("S1", nullptr);


warning: use of undeclared identifier 'strt_S1'; did you mean 'strt_S'? [clang-diagnostic-error]

Suggested change

Cpp::TCppScope_t strt_S1 = Cpp::GetNamed("S1", nullptr);

Cpp::TCppScope_t strt_S = Cpp::GetNamed("S1", nullptr);

Additional context

unittests/CppInterOp/ScopeReflectionTest.cpp:715: 'strt_S' declared here

Cpp::TCppScope_t strt_S = Cpp::GetNamed("S", nullptr); ^

codecov · 2026-06-27T17:37:02Z

Codecov Report

❌ Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.44%. Comparing base (a1c1fc2) to head (3f3854e).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/CppInterOp/CppInterOp.cpp	94.28%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
+ Coverage   86.23%   86.44%   +0.20%     
==========================================
  Files          21       23       +2     
  Lines        5369     5658     +289     
==========================================
+ Hits         4630     4891     +261     
- Misses        739      767      +28

Files with missing lines	Coverage Δ
lib/CppInterOp/CppInterOp.cpp	`89.31% <94.28%> (-0.01%)`	⬇️

... and 4 files with indirect coverage changes

Files with missing lines	Coverage Δ
lib/CppInterOp/CppInterOp.cpp	`89.31% <94.28%> (-0.01%)`	⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add support for inherited members via ShadowDecl

8a0a6b6

github-actions Bot reviewed Jun 19, 2026

View reviewed changes

Update with removing casting to fix CI builds

c51f1c9

github-actions Bot reviewed Jun 27, 2026

View reviewed changes

Update tests

3f3854e

	Cpp::TCppScope_t strt_S1 = Cpp::GetNamed("S1", nullptr);
	Cpp::TCppScope_t; strt_S1 = Cpp::GetNamed("S1", nullptr);

	Cpp::TCppScope_t strt_S1 = Cpp::GetNamed("S1", nullptr);
	Cpp::TCppScope_t strt_S = Cpp::GetNamed("S1", nullptr);

Uh oh!

Conversation

Krishna-13-cyber commented Jun 19, 2026

Description

Type of change

Testing

Checklist

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jun 27, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels