Add GetSignedType and GetUnsignedType#1010
Open
Ivka-F wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
+ Coverage 85.89% 86.06% +0.16%
==========================================
Files 15 15
Lines 4971 5031 +60
==========================================
+ Hits 4270 4330 +60
Misses 701 701
🚀 New features to boost your workflow:
|
4e73fa8 to
83788ec
Compare
Collaborator
|
Can you please fix the Ubuntu CI failures? You may want to use macros for the LLVM version, and if CppInterOp is built with Cling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upstreams two new type utility functions from the jank-lang/CppInterOp fork,
originally authored by @jeaye.
GetSignedType— returns the signed counterpart of an integral type (e.g. unsigned int -> int). Returns the type unchanged if it has no signed counterpart.GetUnsignedType— returns the unsigned counterpart of an integral type (e.g. int -> unsigned int). Returns the type unchanged if it has no unsigned counterpart.Both functions follow the existing API conventions (INTEROP_TRACE, INTEROP_RETURN, null checks) and include unit tests in TypeReflectionTest.cpp covering all integral type cases including __int128.
These are purely additive — no existing behavior is changed.