Fix failing deploy workflow and duplicate CI runs#286
Merged
Conversation
The deploy job had all its steps commented out, which makes the workflow file invalid. GitHub can't parse an invalid workflow to evaluate its branch filter, so every push to any branch logged an instant failed run. Add a placeholder step so the file parses; the Kinsta template steps stay commented below it.
Triggering on both push and pull_request ran every job twice for each commit on a PR branch. Trigger on pushes to main and on pull requests instead, so each change is checked exactly once.
checkout v5 -> v6 in the theme and docker-compose workflows to match ci.yml, setup-node v4 -> v6 in the theme build, and the commented Kinsta template steps now reference checkout v6 and ssh-agent v0.10.0. cache, setup-php and php-actions/composer are already current.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI hygiene fixes:
Deploy workflow failed on every push
deploy.ymlhas all its steps commented out, which makes the workflow file invalid — and GitHub can't parse an invalid workflow to evaluate itsbranches: [main]filter, so every push to every branch logged an instant failed run (all 0s duration, check the Actions tab). Added a placeholder step so the file parses; the commented Kinsta template steps are unchanged.Every check ran twice on PRs
ci.ymlandtheme.ymltriggered on bothpushandpull_request, so each commit on a PR branch ran all jobs twice (visible on #285 — duplicatebuildchecks). All three CI workflows now trigger on pushes to main and on pull requests, so each change is checked exactly once.