fix: Fix file handle and HTTP response resource leaks#1086
Open
lxcxjxhx wants to merge 1 commit into
Open
Conversation
Member
|
Hi @lxcxjxhx and thanks for the contribution! I'll review the changes in more detail over the next few days and, if everything looks good, I'll proceed with the merge. One minor note regarding the PR description: I think "resource management improvements" would be a more accurate description than "resource leak fixes", since the previous implementation was generally cleaned up by Python as well. Also, the PEP 343 reference only applies to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes resource leaks in file handle and HTTP response handling:
setup.py: Fixed unclosed file handle when reading README.md
long_description=open('README.md').read()withstatement for proper cleanupsrc/utils/common.py: Fixed unclosed HTTP response in
create_github_issue()content = _urllib.request.urlopen(request, timeout=settings.TIMEOUT).read()Type of change
Testing
Tested with Python 3.11 on Windows 11:
Impact