Skip to content

[Gamut mapping app] Scale LH improvements #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesnw wants to merge 11 commits into
base: main
Choose a base branch
from
+3 −0
Open

[Gamut mapping app] Scale LH improvements #438

Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b6bf6e2
Add scale lh2 method
jamesnw Feb 14, 2024
effeb3c
Merge branch 'main' of github.com:LeaVerou/color.js into scale-lh2
jamesnw Feb 14, 2024
1daffd0
Merge branch 'main' of github.com:LeaVerou/color.js into scale-lh2
jamesnw Feb 14, 2024
19179bb
Merge branch 'main' of github.com:LeaVerou/color.js into scale-lh2
jamesnw Feb 19, 2024
d932bbb
Show deltas for in gamut colors
jamesnw Feb 19, 2024
2bdee07
Lint
jamesnw Feb 19, 2024
dc66988
Merge branch 'main' of github.com:LeaVerou/color.js into scale-lh2
jamesnw Feb 27, 2024
03f71f5
Separate out delta display
jamesnw Feb 27, 2024
1317647
Apply lh2 improvements directly to lh
jamesnw Feb 27, 2024
86a31d4
Merge branch 'main' of github.com:LeaVerou/color.js into scale-lh2
jamesnw Feb 29, 2024
8bdeb25
Remove white/black, conversion
jamesnw Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/gamut-mapping/methods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,16 @@ const methods = {
label: "Scale LH",
description: "Runs Scale, sets L, H to those of the original color, then runs Scale again.",
compute: (color) => {
if (color.inGamut("p3", { epsilon: 0 })) {
return color.to("p3");
Copy link
Copy Markdown
Member

@LeaVerou LeaVerou Feb 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simply return color? There is no reason to convert it to anything, and any conversion is potentially a lossy operation.

Copy link
Copy Markdown
Contributor Author

@jamesnw jamesnw Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this to match what was happening in the scale method, which returns the color converted to p3. This way, the method returns in a consistent space regardless of whether it starts in gamut or not. Otherwise, the serialized display with switch back and forth between p3 and oklch depending on whether it was in gamut.

(Perhaps the results from all methods should be serialized in a single format- currently some are oklch, and some are p3, making them harder to compare, but that's somewhat orthogonal to the question of whether the Scale LH method should return in a consistent space).

}
let [lightness] = color.to("oklch").coords;
if (lightness >= 1) {
return new Color({ space: "xyz-d65", coords: WHITES["D65"] }).to("p3");
}
else if (lightness <= 0) {
return new Color({ space: "xyz-d65", coords: [0, 0, 0] }).to("p3");
}
let mappedColor = methods.scale.compute(color);
let lch = color.to("oklch").coords;
mappedColor.set({
Expand Down