-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(core): pass configured default_branch to syncWorkspace to prevent hard-reset to wrong branch #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leex279
wants to merge
5
commits into
dev
Choose a base branch
from
fix/issue-1273-sync-workspace-respects-default-branch
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(core): pass configured default_branch to syncWorkspace to prevent hard-reset to wrong branch #1274
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2cfffa9
fix(core): pass configured default_branch to syncWorkspace to prevent…
ff75e20
fix(core/test): address review findings for default_branch PR #1274
934f946
simplify: remove redundant ?? undefined on already-optional defaultBr…
abb6481
fix(review): safe migration default + complete test fixtures for Code…
b1f93a6
fix(review): add SQLite migrateColumns entry for default_branch + fix…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| -- Add default_branch column to remote_agent_codebases. | ||
| -- NULL means "not yet detected"; syncWorkspace falls back to auto-detection | ||
| -- (pre-existing behaviour). New clones set this via the branch-detect path in | ||
| -- clone.ts. Using no DEFAULT so existing rows stay NULL rather than being | ||
| -- silently set to 'main' (which could trigger an unwanted hard-reset for | ||
| -- managed clones on a non-main branch). | ||
| ALTER TABLE remote_agent_codebases | ||
| ADD COLUMN IF NOT EXISTS default_branch TEXT; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Null
default_branchsilently falls back to auto-detect — same root bug for unset rows.When
codebase.default_branchis null,configuredBranchisundefinedandsyncWorkspacere-enters the auto-detect path (git symbolic-ref refs/remotes/origin/HEAD→ typicallymain). For managed clones (resetAfterFetch: true) this will still dogit reset --hard origin/main— the exact behavior issue#1273is trying to avoid.This works for codebases created via the updated clone path (branch is detected and persisted), but two scenarios still hit the bug:
'main'— see my comment on the migration)./register-project(handleRegisterProject at Line 1300 doesn't passdefault_branch, so null is persisted).Consider either (a) detecting HEAD at
/register-projecttime too, or (b) whendefault_branchis null on a managed clone, detecting the local branch viagit rev-parse --abbrev-ref HEADbefore syncing rather than resolving viaorigin/HEAD, and refusing the reset if they disagree.🤖 Prompt for AI Agents