feat(cold-pass): universal checklist + reviewer command for independent PR review#1264
Open
fundedullc-dev wants to merge 2 commits intocoleam00:devfrom
Open
feat(cold-pass): universal checklist + reviewer command for independent PR review#1264fundedullc-dev wants to merge 2 commits intocoleam00:devfrom
fundedullc-dev wants to merge 2 commits intocoleam00:devfrom
Conversation
added 2 commits
April 16, 2026 15:27
Adds the shipped default checklist for cold second-pass PR review. Covers correlated-attention blind spots that 5-agent review misses: one-sided parity, cross-file state, migration hygiene, resource/failure modes, test coverage gaps, downstream consistency, hardcoded values. Used by the archon-cold-pass-review command (Task 3) and by consuming repos' cold-pass slash commands as the universal default that's always layered first, with optional repo-local extension appended after. Maps to spec §5.1 of fundedullc-dev/email-pipeline-dev#75. Refs fundedullc-dev/email-pipeline-dev#75
Adds the reviewer command markdown used by the cold-pass slash command (and by any future cold-pass workflow). Enforces two disciplines: 1. 'First reviewer' framing — Archon's existing findings are consumed ONLY for dedup at the end, never as an attention-anchor up front. 2. Literal walk of checklists — reviewer outputs PASS/FAIL/N/A per item with file:line refs for every FAIL. No summarization; no skipping. Four phases: LOAD (read PR + checklists) -> ANALYZE (walk literally) -> GENERATE (structured findings) -> VALIDATE (completeness check). Maps to spec section 4.2 of fundedullc-dev/email-pipeline-dev#75. Refs fundedullc-dev/email-pipeline-dev#75
📝 WalkthroughWalkthroughTwo new documentation files have been added to establish a universal cold-pass review checklist and an independent second-pass review command workflow. Both files define structured review processes and coverage areas without modifying any code or public entities. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.archon/checklists/cold-pass-default-checklist.md (1)
41-42: Tighten wording for precision in edge-case input list.At Line 41-42, consider replacing “very large input” with a more concrete phrase like “large input sizes” to reduce ambiguity in reviewer interpretation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.archon/checklists/cold-pass-default-checklist.md around lines 41 - 42, Update the checklist item text that currently reads "very large input" to a clearer phrase such as "large input sizes" (or "very large input sizes" if you want to keep emphasis) so the edge-case list is more precise; locate the checklist bullet string "[ ] New parameter handled for empty string, None/null, special characters, very large input?" and replace that final fragment with the chosen clearer wording and keep the punctuation/format consistent with the surrounding checklist items.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.archon/commands/defaults/archon-cold-pass-review.md:
- Around line 59-84: The fenced code block that contains the template starting
with "# 🧊 COLD PASS: PR #<N>" is missing a language identifier (lint rule
MD040); fix it by changing the opening fence from ``` to ```md (i.e., add the
"md" language tag) so the block is explicitly marked as Markdown while leaving
the closing fence unchanged.
---
Nitpick comments:
In @.archon/checklists/cold-pass-default-checklist.md:
- Around line 41-42: Update the checklist item text that currently reads "very
large input" to a clearer phrase such as "large input sizes" (or "very large
input sizes" if you want to keep emphasis) so the edge-case list is more
precise; locate the checklist bullet string "[ ] New parameter handled for empty
string, None/null, special characters, very large input?" and replace that final
fragment with the chosen clearer wording and keep the punctuation/format
consistent with the surrounding checklist items.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1e0ba3c8-d343-4980-a7fd-85a620aa103f
📒 Files selected for processing (2)
.archon/checklists/cold-pass-default-checklist.md.archon/commands/defaults/archon-cold-pass-review.md
Comment on lines
+59
to
+84
| ``` | ||
| # 🧊 COLD PASS: PR #<N> | ||
|
|
||
| **Reviewer model:** <state the model you are, e.g., `gpt-5.3-codex` or `claude-opus-4.6` — name the actual model you run as> | ||
| **Checklist source:** <`default` or `repo+default` — read from `$ARTIFACTS_DIR/.checklist-source`> | ||
| **Verdict:** <APPROVE or REQUEST_CHANGES> | ||
|
|
||
| ## HIGH | ||
| - <file:line> — <finding> | ||
|
|
||
| ## MEDIUM | ||
| - <file:line> — <finding> | ||
|
|
||
| ## LOW | ||
| - <file:line> — <finding> | ||
|
|
||
| ## Deduplication note | ||
|
|
||
| After reading `gh pr view <PR> --comments`, I removed findings Archon already | ||
| caught at the same or higher severity. Findings retained below are either new, | ||
| or graded higher than Archon did (with reasoning). | ||
|
|
||
| ## Summary | ||
|
|
||
| <One paragraph. If nothing beyond Archon, say: "No additional findings. APPROVE."> | ||
| ``` |
There was a problem hiding this comment.
Add a language tag to the fenced block to satisfy markdownlint.
At Line 59, the fenced code block is missing a language identifier (MD040). If linting is enforced, this can fail docs checks.
Suggested fix
-```
+```md
# 🧊 COLD PASS: PR #<N>
@@
-```
+```📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| ``` | |
| # 🧊 COLD PASS: PR #<N> | |
| **Reviewer model:** <state the model you are, e.g., `gpt-5.3-codex` or `claude-opus-4.6` — name the actual model you run as> | |
| **Checklist source:** <`default` or `repo+default` — read from `$ARTIFACTS_DIR/.checklist-source`> | |
| **Verdict:** <APPROVE or REQUEST_CHANGES> | |
| ## HIGH | |
| - <file:line> — <finding> | |
| ## MEDIUM | |
| - <file:line> — <finding> | |
| ## LOW | |
| - <file:line> — <finding> | |
| ## Deduplication note | |
| After reading `gh pr view <PR> --comments`, I removed findings Archon already | |
| caught at the same or higher severity. Findings retained below are either new, | |
| or graded higher than Archon did (with reasoning). | |
| ## Summary | |
| <One paragraph. If nothing beyond Archon, say: "No additional findings. APPROVE."> | |
| ``` |
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 59-59: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.archon/commands/defaults/archon-cold-pass-review.md around lines 59 - 84,
The fenced code block that contains the template starting with "# 🧊 COLD PASS:
PR #<N>" is missing a language identifier (lint rule MD040); fix it by changing
the opening fence from ``` to ```md (i.e., add the "md" language tag) so the
block is explicitly marked as Markdown while leaving the closing fence
unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Archon's
archon-comprehensive-pr-reviewis excellent at catching per-file issues but has a documented correlated-attention blind spot for bugs that drift across files (producer/consumer parity, cross-file state, silent-200s). Running an independent cold second-pass after the 5-agent review catches these.This PR adds two reusable artifacts that support the pattern — both pure markdown, no execution dependencies:
.archon/checklists/cold-pass-default-checklist.md— universal checklist of correlated-attention blind spots (one-sided parity, cross-file state machines, migration hygiene, resource/failure modes, test coverage, downstream consistency, hardcoded values). 23 literal checklist items..archon/commands/defaults/archon-cold-pass-review.md— the reviewer command with a 4-phase walk (LOAD → ANALYZE → GENERATE → VALIDATE). Enforces "first reviewer" framing: Archon's existing findings are consumed ONLY at the end for deduplication, never as an attention anchor up front.What this is NOT
archon workflow runfrom inside a bash node. Empirical testing (fundedullc-dev/email-pipeline-dev#75, Wave 1 probe findings) showed the current bash-node execution model blocks this approach:archonbinary is not on PATH inside bash nodes, bash stdout is silenced on success, and Windows$ARTIFACTS_DIRsubstitution produces broken paths when spliced into bash strings. A cold-pass workflow YAML can land once those execution concerns are addressed upstream; in the meantime these markdown artifacts are useful as standalone reference material for any reviewer (agentic or human) that wants to walk the checklist.Cold-pass precedents
Real bugs caught by manual cold-pass on PRs that Archon's 5-agent review had already approved:
fundedullc-dev/fundedu-hivePR [FEATURE] How about bootstrapping the agent builder? #4 — UPDATE-only migration silently no-op'd on fresh DBsfundedullc-dev/fundedu-hivePR added missing file future_enhancements.py to v4 iteration dir. #46 —track_data_file()write path drifted fromget_state_files()read path across three storage backendsfundedullc-dev/email-pipeline-devissue Bump beautifulsoup4 from 4.12.3 to 4.13.3 #80 —retry_failed_contactsdoesn't passforce_override_emailsto presend gate (one-sided parity with two sibling send paths)These are the bug shapes the checklist is engineered to surface, specifically the
ONE-SIDED PARITYsection.Validation evidence
Smoke-tested 2026-04-16 against email-pipeline-dev PR #66 using a consumer-side slash command that reads these artifacts and invokes Codex (gpt-5 family) on the PR diff. Cold-pass successfully:
Evidence comment: https://github.com/fundedullc-dev/email-pipeline-dev/pull/66#issuecomment-4262997447
Design spec
Full spec + architectural rationale + Wave 1 probe findings: https://github.com/fundedullc-dev/email-pipeline-dev/tree/main/docs/superpowers
Key design principles:
Files changed
.archon/checklists/cold-pass-default-checklist.md(new, 2.9 KB, 23 checklist items).archon/commands/defaults/archon-cold-pass-review.md(new, 3.5 KB, 4-phase walk)No existing files modified. Additive only.
Questions welcomed
.archon/checklists/is the wrong path for bundled-default artifacts (Archon's shipped workflows live inpackages/workflows/src/defaults/bundled-defaults.ts— perhaps the checklist + command should be similarly bundled), happy to relocate.Authored by @fundedullc-dev. Validation done in https://github.com/fundedullc-dev/email-pipeline-dev/issues/75.
Summary by CodeRabbit