Fixed can't work if this component is used in sub container. - #4
Conversation
|
Hey! Thank you for improving this component! Can you please provide us with further documentation on how to apply the scrolling behaviour to a subcontainer? I tried this : but could not make it work :( EDIT : finally works as intended ! My imports did not point to your version of the component but to the master one. Thank you for the good work ! :) |
|
Glad it helps! I should add the usage of the attributes in README. |
| isolate: { | ||
| onePageHeight: null, | ||
| timeoutFuncHandler: null, | ||
| excludeTopMargin: null, |
There was a problem hiding this comment.
@malikid
Thanks so much for your pr, one question, is the prop excludeTopMargin works same as the prop excludeHeight, if so, maybe you can comment hte excludeHeight as deprecated.
|
@malikid |
Related to #2 . What I added are two optional attributes for users deciding to use custom "window" and "document" (when used in a container) or the default ones.