fix: update Microsoft Teams message structure and theme color handling#5363
Open
SteKoe wants to merge 1 commit into
Open
fix: update Microsoft Teams message structure and theme color handling#5363SteKoe wants to merge 1 commit into
SteKoe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the Microsoft Teams notifier implementation in the Spring Boot Admin server to use Adaptive Cards instead of the legacy message format, improving compatibility with Microsoft Teams and enhancing message structure and flexibility. It also updates the tests to validate the new message format and color handling.
Migration to Adaptive Card format for Microsoft Teams notifications:
MicrosoftTeamsNotifierto construct Adaptive Card messages, replacing the legacySection-based format with a new structure usingMessage,Attachment,AdaptiveCard, andCardElementclasses. The new format organizes message content into a card body with title, service name, subtitle, and a fact set, improving Teams compatibility and presentation. [1] [2]"Good","Attention","Accent") instead of hex codes, updating both the default color expression and all references in code and tests. [1] [2]Enhancements and code quality improvements:
addFactIfNotNullto only include non-null facts in the notification payload, ensuring cleaner messages.Factrecord to usetitleinstead ofnameto match the Adaptive Card schema.Test suite updates:
These changes modernize Microsoft Teams integration, improve maintainability, and ensure robust test coverage for the new notification format.
Example
fixes #5321