Skip to content

Add yamllint check for config.yaml#1554

Merged
jeefy merged 2 commits intocncf:mainfrom
cblecker:add-yamllint-check
Mar 12, 2026
Merged

Add yamllint check for config.yaml#1554
jeefy merged 2 commits intocncf:mainfrom
cblecker:add-yamllint-check

Conversation

@cblecker
Copy link
Copy Markdown
Member

@cblecker cblecker commented Mar 11, 2026

Summary

  • Add yamllint to the CI validation workflow for early syntax checking of config.yaml (duplicate keys, trailing whitespace, indentation errors)
  • Add .yamllint config to tune rules for the project's style (relaxed comment spacing, no document-start or line-length enforcement)
  • Fix existing issues in config.yaml: duplicate dwelsch-esi key in techdocs external_collaborators, trailing whitespace on two lines

Test plan

  • Verify yamllint -s config.yaml passes
  • Verify check-jsonschema --schemafile schema.json people.json still passes
  • Verify CI workflow runs both validation steps on a PR

@clowarden
Copy link
Copy Markdown

clowarden bot commented Mar 11, 2026

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

No actionable changes detected.


🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

@cblecker cblecker force-pushed the add-yamllint-check branch from 26a079c to a8f2405 Compare March 11, 2026 20:09
@clowarden
Copy link
Copy Markdown

clowarden bot commented Mar 11, 2026

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

No actionable changes detected.


🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

Assisted-by: Claude:claude-opus-4-6
Signed-off-by: Christoph Blecker <admin@toph.ca>
Assisted-by: Claude:claude-opus-4-6
Signed-off-by: Christoph Blecker <admin@toph.ca>
@cblecker cblecker force-pushed the add-yamllint-check branch from a8f2405 to e9fda74 Compare March 11, 2026 20:11
@clowarden
Copy link
Copy Markdown

clowarden bot commented Mar 11, 2026

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

No actionable changes detected.


🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

@jeefy jeefy merged commit 6631228 into cncf:main Mar 12, 2026
4 checks passed
@clowarden
Copy link
Copy Markdown

clowarden bot commented Mar 12, 2026

Reconciliation completed

✅ The reconciliation completed successfully and all changes have been applied across the services!

Changes applied

No actionable changes detected.

@cblecker cblecker deleted the add-yamllint-check branch March 12, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants