Intergration of TOoLLiP_v3.#51057
Draft
Brainz22 wants to merge 2 commits into
Draft
Conversation
Contributor
|
cms-bot internal usage |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51057/49508 |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51057/49561 |
Contributor
|
Pull request #51057 was updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
This PR integrates TOoLLiP_v3 into CMSSW, which involves the newest development of the Level-1 long-lived-particle jet trigger. The official TOoLLiP development repository is found here.
TOoLLiP/TOoLLiP_v3and linked here, e.g. ROC curves, HLS firmwareTOoLLiP_v3folder, Python to HLS conversion scripts, and layer tracing, and model plots.The PR to pass in the correct TOoLLiP version on
cms-sw/cmsdistcan be found herePR validation:
perfNano.rootwill appeat at$PWD. This ntuple contains the branchscPuppiL1TTOOLLIPJet_llpTagScoreas defined by the lines here.TOoLLiP_v3emulation checks have been performed on signal and minbias samples, where inputs are taken from cmssw directly and used to testqkerasandHLSmodels. Their predictions are compared against the emulation predictions. Plot are shown below (original_scoreaxis has distribution ofqkerasmodel predictions):The
qkerasmodel outputs differ fromhls(and thus,cmssw) outputs due to arithmetic precision and quantization mismatches in the shift fromqkerastohls. This conclusion can be inferred from the spread in thehlsandqkerasmodel final layer outputs:No backports needed. The workflow works fine for CMSSW_17_0_0_pre1.