Skip to content

Upgrade EvtGen to v03.00.00#10580

Open
kawaho wants to merge 4 commits into
cms-sw:IB/CMSSW_17_0_X/masterfrom
kawaho:EvtGenv3
Open

Upgrade EvtGen to v03.00.00#10580
kawaho wants to merge 4 commits into
cms-sw:IB/CMSSW_17_0_X/masterfrom
kawaho:EvtGenv3

Conversation

@kawaho
Copy link
Copy Markdown

@kawaho kawaho commented May 25, 2026

This commits upgrade EvtGen to v03.00.00, which

  • is now thread-safe, allowing multithreading in production
  • adds new final state photon radiation models in Sherpa/Photon++ and Vincia
  • includes new physics models and decay table implemented by Belle 2

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @kawaho for branch IB/CMSSW_17_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 25, 2026

cms-bot internal usage

@akritkbehera
Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51029

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53469/summary.html
COMMIT: 8089a4f
CMSSW: CMSSW_17_0_X_2026-05-25-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10580/53469/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 10 errors in the following unit tests:

---> test GeneratorInterfaceEvtGenInterfaceTest had ERRORS
---> test TestGeneratorInterfaceEvtGenInterface_bplus had ERRORS
---> test test_MC_22_crosscheck had ERRORS
and more ...

Failed RelVals

  • 25202.0A fatal system signal has occurred: segmentation violation
  • 25.0A fatal system signal has occurred: segmentation violation
  • 1306.0A fatal system signal has occurred: segmentation violation
Expand to see more relval errors ...

Failed AddOn Tests

A fatal system signal has occurred: segmentation violation
----- Begin Fatal Exception 26-May-2026 00:52:06 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Attempted to open logical file file:RelVal_Raw_Fake_MC.root.
      [b] Failed to open the file with physical name file:RelVal_Raw_Fake_MC.root.
      [c] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 256. Asked to read n bytes: 300 from offset: 0 with file size: 256

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 26-May-2026 00:52:28 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Attempted to open logical file file:RelVal_Raw_Fake_MC.root.
      [b] Failed to open the file with physical name file:RelVal_Raw_Fake_MC.root.
      [c] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 256. Asked to read n bytes: 300 from offset: 0 with file size: 256

----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@kawaho
Copy link
Copy Markdown
Author

kawaho commented May 26, 2026

@akritkbehera how do I run these tests locally? They look strange because all the errors seem to be coming from GEANT4 which is not changed in this commit.

@smuzaffar
Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51029 using full cmssw

lets build full cmssw

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53479/summary.html
COMMIT: 8089a4f
CMSSW: CMSSW_17_0_X_2026-05-25-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10580/53479/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53479/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53479/git-merge-result

Failed Unit Tests

I found 10 errors in the following unit tests:

---> test test_MC_22_crosscheck had ERRORS
---> test test_MC_23_crosscheck had ERRORS
---> test GeneratorInterfaceEvtGenInterfaceTest had ERRORS
and more ...

Failed RelVals

  • 25202.0A fatal system signal has occurred: segmentation violation
  • 25.0A fatal system signal has occurred: segmentation violation
  • 1306.0A fatal system signal has occurred: segmentation violation
Expand to see more relval errors ...

Failed AddOn Tests

A fatal system signal has occurred: segmentation violation
----- Begin Fatal Exception 26-May-2026 13:12:11 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Attempted to open logical file file:RelVal_Raw_Fake_MC.root.
      [b] Failed to open the file with physical name file:RelVal_Raw_Fake_MC.root.
      [c] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 256. Asked to read n bytes: 300 from offset: 0 with file size: 256

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 26-May-2026 13:12:33 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Attempted to open logical file file:RelVal_Raw_Fake_MC.root.
      [b] Failed to open the file with physical name file:RelVal_Raw_Fake_MC.root.
      [c] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 256. Asked to read n bytes: 300 from offset: 0 with file size: 256

----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@kawaho
Copy link
Copy Markdown
Author

kawaho commented May 27, 2026

The GEANT4 crush is most likely due to the dependence on SimG4Core I introduced in GeneratorInterface/ExternalDecays. This should be resolved by #51041. Let's wait for it to be merged so I can modify my commit according to the new build

@kawaho
Copy link
Copy Markdown
Author

kawaho commented May 28, 2026

@smuzaffar

Ready to test. ThreadHandoff is moved now in the new commit.

@smuzaffar
Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51029 using full cmssw

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53550/summary.html
COMMIT: 8089a4f
CMSSW: CMSSW_17_0_X_2026-05-28-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10580/53550/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed External Build

I found compilation warning when building: See details on the summary page.

@kawaho
Copy link
Copy Markdown
Author

kawaho commented May 28, 2026

hepforge seems to be down right now....

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53557/summary.html
COMMIT: 8089a4f
CMSSW: CMSSW_17_0_X_2026-05-28-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10580/53557/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 3 errors in the following unit tests:

---> test TestGeneratorInterfaceEvtGenInterface_bplus had ERRORS
---> test GeneratorInterfaceEvtGenInterfaceTest had ERRORS
---> test TestGeneratorInterfaceEvtGenInterface_external_bplus had ERRORS

Comparison Summary

Summary:

  • You potentially removed 173 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4198477
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4198448
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@kawaho
Copy link
Copy Markdown
Author

kawaho commented May 29, 2026

Unit tests failed because of MPI in Sherpa

*** The MPI_Comm_rank() function was called before MPI_INIT was invoked.
*** This is disallowed by the MPI standard.
*** Your MPI job will now abort.

It is fine when I build Sherpa without MPI....I need to find a way to disable it for the unit tests....

@kawaho
Copy link
Copy Markdown
Author

kawaho commented May 29, 2026

@smuzaffar #10211 seems to be related...does OMPI_MCA_accelerator=null propagate when one does cmsDriver.py or cmsRun? Or are there tricks to turn it off?

@smuzaffar
Copy link
Copy Markdown
Contributor

smuzaffar commented May 29, 2026

@kawaho , yes OMPI_MCA_accelerator=null is seen by cmsDriver/cmsRun. It is set when one runs cmsenv to set cmssw runtime env. As mentioned in #10211, we set this to make sure OpenMPI does not call setenv ( which is not threadsafe and we have seen runtime crashes due to that)

@smuzaffar
Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51029, #10594

@smuzaffar
Copy link
Copy Markdown
Contributor

please test workflows 534.0, 536.0 with cms-sw/cmssw#51029, #10594

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53578/summary.html
COMMIT: 8089a4f
CMSSW: CMSSW_17_0_X_2026-05-29-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10580/53578/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53578/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53578/git-merge-result

Failed Unit Tests

I found 3 errors in the following unit tests:

---> test TestGeneratorInterfaceEvtGenInterface_bplus had ERRORS
---> test GeneratorInterfaceEvtGenInterfaceTest had ERRORS
---> test TestGeneratorInterfaceEvtGenInterface_external_bplus had ERRORS

Comparison Summary

Summary:

@kawaho
Copy link
Copy Markdown
Author

kawaho commented May 29, 2026

The unit tests now run fine with my latest commit. Tested locally with a build of sherpa with mpi

Singularity> scram b runtests_TestGeneratorInterfaceEvtGenInterface_bplus                                                                                                                                       
>> Local Products Rules ..... started
>> Local Products Rules ..... done
Creating test log file logs/el8_amd64_gcc13/testing.log
Pass  210s ... GeneratorInterface/EvtGenInterface/TestGeneratorInterfaceEvtGenInterface_bplus
Singularity> scram b runtests_GeneratorInterfaceEvtGenInterfaceTest      
>> Local Products Rules ..... started
>> Local Products Rules ..... done
Creating test log file logs/el8_amd64_gcc13/testing.log
Pass  281s ... GeneratorInterface/EvtGenInterface/GeneratorInterfaceEvtGenInterfaceTest
Singularity> scram b runtests_TestGeneratorInterfaceEvtGenInterface_external_bplus
>> Local Products Rules ..... started
>> Local Products Rules ..... done
Creating test log file logs/el8_amd64_gcc13/testing.log
Pass  220s ... GeneratorInterface/EvtGenInterface/TestGeneratorInterfaceEvtGenInterface_external_bplus

@smuzaffar can we test again

@smuzaffar
Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51029

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53590/summary.html
COMMIT: 8089a4f
CMSSW: CMSSW_17_0_X_2026-05-29-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10580/53590/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53590/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29dd1/53590/git-merge-result

Comparison Summary

Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants