Skip to content

adopt standard ruby formatting#613

Merged
mkocher merged 1 commit into
ubuntu-jammyfrom
jammy-standard-rb
Jun 5, 2026
Merged

adopt standard ruby formatting#613
mkocher merged 1 commit into
ubuntu-jammyfrom
jammy-standard-rb

Conversation

@mkocher
Copy link
Copy Markdown
Member

@mkocher mkocher commented Jun 5, 2026

This was already being done inside the bosh-stemcell gem, now adding it at the top level as well.

This was already being done inside the bosh-stemcell gem, now adding
it at the top level as well.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

Need the big picture first? Review this PR in Change Stack to see what changed before going file by file.

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 69cf26a7-d968-4d7a-b498-ba92a5f2c589

📥 Commits

Reviewing files that changed from the base of the PR and between e603eb3 and ef1e590.

⛔ Files ignored due to path filters (1)
  • Gemfile.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • Gemfile
  • Rakefile
  • ci/tasks/light-aws/merge-builds

Walkthrough

This pull request applies a codebase-wide refactoring focused on code style consistency and linting infrastructure. The Gemfile is reformatted to use double-quoted strings for gem declarations. The Rakefile adds a require for standard/rake (linting support), refactors error handling in two build tasks from explicit begin/rescue blocks to inline rescue syntax, and normalizes all string literals to double quotes. The merge-builds script in ci/tasks/light-aws/ is updated with consistent double-quoted strings, a simplified run_command implementation, and double-quoted YAML key access. All functional behavior in build tasks and script logic remains unchanged.

Suggested reviewers

  • selzoc
  • ragaskar
  • ystros
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description provides context about the change but does not follow the required 'Merge Forward' strategy template with branch naming and PR sequencing instructions. Update the description to follow the repository's Merge Forward strategy template, including information about target branch, any merge-forward PRs needed, and the appropriate branch naming convention.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adopting standard Ruby formatting across the repository's top-level files (Gemfile, Rakefile, and shell scripts).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jammy-standard-rb

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jun 5, 2026
@mkocher mkocher merged commit 0aef26c into ubuntu-jammy Jun 5, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jun 5, 2026
@mkocher mkocher deleted the jammy-standard-rb branch June 5, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant