feat: add ArtifactsError type definitions

[dmmulroy]

What

Add ArtifactsError and ArtifactsErrorCode TypeScript type definitions to the Artifacts binding.

Changes

types/defines/artifacts.d.ts:

• ArtifactsErrorCode — union of all error code strings (ALREADY_EXISTS, NOT_FOUND, INVALID_INPUT, etc.)
• ArtifactsError — extends Error with readonly code: ArtifactsErrorCode and readonly numericCode: number
• @throws {ArtifactsError} annotations on all Artifacts and ArtifactsRepo methods

Follows the same interface extends Error pattern used by StreamError, ImagesError, and MediaError.

Snapshot

generated-snapshot/ needs regeneration — CI will flag the diff and produce the updated snapshot artifact. I was unable to run just generate-types locally due to a bazel cache issue unrelated to this change.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.62%. Comparing base (ac31559) to head (a9024c1).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6710   +/-   ##
=======================================
  Coverage   66.62%   66.62%           
=======================================
  Files         402      402           
  Lines      115914   115914           
  Branches    19425    19425           
=======================================
  Hits        77226    77226           
  Misses      27095    27095           
  Partials    11593    11593           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jamesopstad]

/bonk review this PR

[ask-bonk]

AI-generated review (by OpenCode). May contain inaccuracies — please verify.

Summary: The types look well-structured and follow existing Cloudflare binding error patterns. A few items to address:

• The generated-snapshot/ files should not be hand-edited — CI should regenerate them. The manual edits will likely be overwritten and may cause the snapshot CI check to fail until just generate-types is run.
• Several error codes in ArtifactsErrorCode are never referenced in any @throws annotation. Either they can be thrown (and should be documented) or they're unused.
• Minor: the import() method documents INVALID_INPUT for bad URLs, but a more specific INVALID_URL code exists in the union and seems like a better fit.

[ask-bonk]

Review posted successfully. Here's a summary of the feedback I left on PR #6710:

3 inline comments:

1. types/defines/artifacts.d.ts:149-161 — Five error codes (INVALID_URL, REMOTE_AUTH_REQUIRED, UPSTREAM_UNAVAILABLE, MEMORY_LIMIT, INTERNAL_ERROR) are in the ArtifactsErrorCode union but never appear in any @throws annotation. Asked whether they should be documented on specific methods, especially import() and fork().

2. types/defines/artifacts.d.ts:210 — The import() method documents INVALID_INPUT for bad source URLs, but a more specific INVALID_URL code exists in the union. Flagged a possible mismatch.

3. types/generated-snapshot/experimental/index.d.ts:11894 — Per repo convention, generated-snapshot/ files should not be hand-edited. The PR description acknowledges a local bazel issue prevented running just generate-types, but the manual edits may diverge from generator output. CI should flag this.

github run

[jamesopstad]

Hi @dmmulroy. Can you address/resolve the bonk review comments and then I'll give it another look before approving? Thanks.

[codspeed-hq]

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks¹

---

_{Comparing dmmulroy:dillon/artifacts-error-types (a9024c1) with main (ac31559)}

Footnotes

1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[dmmulroy]

Hi @dmmulroy. Can you address/resolve the bonk review comments and then I'll give it another look before approving? Thanks.

Addressed 🫡

h/t @dinasaur404 for help on it

[dinasaur404]

/bonk review the PR