ffi: don't unecessarily use a slice when constructing SockAddr#2475
Merged
Conversation
The optional_std_addr_from_c function only accepts a single sockaddr. We can avoid potential UB caused by using a slice (as in the prior version) by constructing directly.
LPardue
force-pushed
the
fix-sockaddr-soundness
branch
from
83dbdd1 to
46513a5
Compare
ghedo
approved these changes
May 13, 2026
jannes
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional_std_addr_from_c function only accepts a single sockaddr.
We can avoid potential UB caused by using a slice (as in the prior version)
by constructing directly.