docs(cache): Clarify custom cache key behavior with single-file purge#32107
Open
mbullock1986 wants to merge 1 commit into
Open
docs(cache): Clarify custom cache key behavior with single-file purge#32107mbullock1986 wants to merge 1 commit into
mbullock1986 wants to merge 1 commit into
Conversation
Cache Rules that set custom cache keys require API purge with headers/cookies rather than dashboard single-file purge. This clarification reduces customer escalations about why single-file purge does not invalidate cached resources.
Contributor
Review💡 2 suggestions found in commit Fix in your agentFix the following review findings in PR #32107 (https://github.com/cloudflare/cloudflare-docs/pull/32107).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.
---
## Style Guide Review
### Suggestions (2)
#### SG-12fd64d3f601 · Passive voice
- **File:** `src/content/docs/cache/how-to/cache-rules/index.mdx` line 35
- **Issue:** Line uses passive voice: "the resulting cache entry is indexed by that key".
- **Fix:** Rewrite in active voice, e.g. "that key indexes the cache entry rather than the request URL alone."
#### SG-c08c1dbeb9e7 · Passive voice
- **File:** `src/content/docs/cache/how-to/purge-cache/purge-by-single-file.mdx` line 32
- **Issue:** Added line uses passive voice: 'it is treated as an empty value in the cache key.'
- **Fix:** Rewrite in active voice, e.g., 'The cache treats any missing header or cookie as an empty value.'
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewSuggestions (2)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache Rules that set custom cache keys require API purge with headers/cookies rather than dashboard single-file purge. This clarification reduces customer escalations about why single-file purge does not invalidate cached resources.
Summary
Screenshots (optional)
Documentation checklist