Skip to content

Fix alarm exception caused by constructor consuming alarm before runtime delivery #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haggbart wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix alarm exception caused by constructor consuming alarm before runtime delivery #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/alarms/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ export class Alarms<P extends DurableObject<any>> {
}
}

// Execute any pending alarms and schedule the next alarm
await this.alarm();
// Don't execute callbacks; the runtime delivers the alarm after init.
await this._scheduleNextAlarm();
});
});
}
Expand Down Expand Up @@ -268,9 +268,9 @@ export class Alarms<P extends DurableObject<any>> {
private async _scheduleNextAlarm() {
// Find the next schedule that needs to be executed
const result = this.sql`
SELECT time, COALESCE(identifier, 'default') as identifier FROM _actor_alarms
SELECT time, COALESCE(identifier, 'default') as identifier FROM _actor_alarms
WHERE time > ${Math.floor(Date.now() / 1000)}
ORDER BY time ASC
ORDER BY time ASC
LIMIT 1
`;
if (!result || !this.storage) return;
Expand Down Expand Up @@ -318,7 +318,7 @@ export class Alarms<P extends DurableObject<any>> {
// Update next execution time for cron schedules
const nextExecutionTime = getNextCronTime(row.cron);
const nextTimestamp = Math.floor(nextExecutionTime.getTime() / 1000);

this.sql`
UPDATE _actor_alarms SET time = ${nextTimestamp} WHERE id = ${row.id}
`;
Expand Down