CBP-47071: make the 'create-namespace' helm install input configurable, defaults to 'true'#68
Conversation
…e, defaults to 'true'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
create-namespaceinput andrelease-revisionoutputSummary
create-namespaceinput (defaulttrue) that controls whether Skaffold creates the target namespace if it does not exist. Previously this was hardcoded to true with no way to opt out.release-revisionoutput that exposes the Helm release revision number after a successful install or upgrade. Returns an empty string for dry-run executions.create-namespacescenarios: false into an existing namespace (positive — expects a revision), true into a new namespace (positive — expects a revision), and false into a missing namespace (negative — expects no revision).Test plan
create-namespaceset tofalseinto existing namespace — verifies release-revision is non-emptycreate-namespaceset totrueinto new namespace — verifies release-revision is non-empty in a freshly created namespacecreate-namespaceset tofalseinto non-existent namespace — verifies the install fails gracefully and release-revision is empty