Skip to content

feat(init): install the clerk-expo setup skill for Expo projects#328

Open
manovotny wants to merge 1 commit into
mainfrom
manovotny/init-expo-setup-skill
Open

feat(init): install the clerk-expo setup skill for Expo projects#328
manovotny wants to merge 1 commit into
mainfrom
manovotny/init-expo-setup-skill

Conversation

@manovotny

Copy link
Copy Markdown

clerk init on Expo projects only installs clerk-expo-patterns. The expo entry in FRAMEWORK_SKILL_MAP (#86, April) predates the mobile/clerk-expo setup skill (clerk/skills@7f7b6ea, May), so the dedicated Expo setup skill never made it into the init flow.

This makes the framework skill map support multiple skills per framework and adds clerk-expo for Expo inits. Prompt summary becomes (clerk-cli + core + features + expo + expo-patterns).

If the exclusion was deliberate, feel free to close — we'll note the intent in docs instead. Surfaced while tightening CLI ↔ Skills cross-referencing in clerk-docs#3427 (DOCS-11816).

The expo entry in FRAMEWORK_SKILL_MAP (added in #86, 2026-04) predates the mobile/clerk-expo setup skill (added to clerk/skills in 2026-05), so Expo inits only got clerk-expo-patterns. The map now supports multiple skills per framework and Expo installs both.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: aa36552

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
clerk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR refactors the skills system to support multiple framework-specific skills per framework. The change updates FRAMEWORK_SKILL_MAP to map frameworks to arrays of skills instead of single strings, introduces getFrameworkSkills() to retrieve all mapped skills, and modifies skill resolution and formatting to operate on arrays. The resolveUpstreamSkills() function now includes all framework-mapped skills, and installSkills() derives and displays the full skill list during interactive confirmation. Tests verify the behavior for Expo (which now maps to both "clerk-expo" and "clerk-expo-patterns"), and release notes document the update.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately captures the main objective: adding the clerk-expo setup skill to Expo project initialization, which is the primary change across all modified files.
Description check ✅ Passed The description is directly related to the changeset, explaining the historical context, the rationale for the change, and the resulting behavior modification.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/cli-core/src/commands/init/skills.ts`:
- Around line 70-72: getFrameworkSkills currently returns the original array
from FRAMEWORK_SKILL_MAP which allows external mutation; change
getFrameworkSkills to return an immutable copy of the skills array (e.g., create
a new array via slice/spread or Object.freeze) when
FRAMEWORK_SKILL_MAP[frameworkDep] exists, while still returning an empty array
for unknown frameworkDep, so callers cannot modify the global
FRAMEWORK_SKILL_MAP contents.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d7d6df06-9251-4bce-91ff-470e6da2f40b

📥 Commits

Reviewing files that changed from the base of the PR and between 4bd85a8 and aa36552.

📒 Files selected for processing (3)
  • .changeset/init-expo-setup-skill.md
  • packages/cli-core/src/commands/init/skills.test.ts
  • packages/cli-core/src/commands/init/skills.ts

Comment on lines +70 to 72
export function getFrameworkSkills(frameworkDep: string | undefined): string[] {
return (frameworkDep && FRAMEWORK_SKILL_MAP[frameworkDep]) || [];
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Return an immutable/copy value from getFrameworkSkills to prevent global map mutation.

Line 71 currently leaks the original array stored in FRAMEWORK_SKILL_MAP. Because this function is exported, any caller can mutate that array and silently change future skill resolution/install behavior.

Suggested fix
-export function getFrameworkSkills(frameworkDep: string | undefined): string[] {
-  return (frameworkDep && FRAMEWORK_SKILL_MAP[frameworkDep]) || [];
+export function getFrameworkSkills(frameworkDep: string | undefined): readonly string[] {
+  const skills = frameworkDep ? FRAMEWORK_SKILL_MAP[frameworkDep] : undefined;
+  return skills ? [...skills] : [];
 }
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/cli-core/src/commands/init/skills.ts` around lines 70 - 72,
getFrameworkSkills currently returns the original array from FRAMEWORK_SKILL_MAP
which allows external mutation; change getFrameworkSkills to return an immutable
copy of the skills array (e.g., create a new array via slice/spread or
Object.freeze) when FRAMEWORK_SKILL_MAP[frameworkDep] exists, while still
returning an empty array for unknown frameworkDep, so callers cannot modify the
global FRAMEWORK_SKILL_MAP contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant