Skip to content

feat: add WASAPI loopback capture mixed with microphone (Windows) #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MoulinLouis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add WASAPI loopback capture mixed with microphone (Windows) #1259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions src-tauri/src/actions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,19 +411,26 @@ impl ShortcutAction for TranscribeAction {
// Get the microphone mode to determine audio feedback timing
let settings = get_settings(app);
let is_always_on = settings.always_on_microphone;
debug!("Microphone mode - always_on: {}", is_always_on);
let is_loopback = rm.is_loopback_mode();
debug!(
"Microphone mode - always_on: {}, loopback: {}",
is_always_on, is_loopback
);

let mut recording_error: Option<String> = None;
if is_always_on {
// Always-on mode: Play audio feedback immediately, then apply mute after sound finishes
debug!("Always-on mode: Playing audio feedback immediately");
let rm_clone = Arc::clone(&rm);
let app_clone = app.clone();
let loopback = is_loopback;
// The blocking helper exits immediately if audio feedback is disabled,
// so we can always reuse this thread to ensure mute happens right after playback.
std::thread::spawn(move || {
play_feedback_sound_blocking(&app_clone, SoundType::Start);
rm_clone.apply_mute();
if !loopback {
rm_clone.apply_mute();
}
});

if let Err(e) = rm.try_start_recording(&binding_id) {
Expand All @@ -441,13 +448,14 @@ impl ShortcutAction for TranscribeAction {
// Small delay to ensure microphone stream is active
let app_clone = app.clone();
let rm_clone = Arc::clone(&rm);
let loopback = is_loopback;
std::thread::spawn(move || {
std::thread::sleep(std::time::Duration::from_millis(100));
debug!("Handling delayed audio feedback/mute sequence");
// Helper handles disabled audio feedback by returning early, so we reuse it
// to keep mute sequencing consistent in every mode.
play_feedback_sound_blocking(&app_clone, SoundType::Start);
rm_clone.apply_mute();
if !loopback {
rm_clone.apply_mute();
}
});
}
Err(e) => {
Expand Down Expand Up @@ -504,9 +512,12 @@ impl ShortcutAction for TranscribeAction {
change_tray_icon(app, TrayIconState::Transcribing);
show_transcribing_overlay(app);

// Unmute before playing audio feedback so the stop sound is audible
rm.remove_mute();

let is_loopback = rm.is_loopback_mode();
// Skip unmute in loopback mode — mute was never applied
if !is_loopback {
// Unmute before playing audio feedback so the stop sound is audible
rm.remove_mute();
}
// Play audio feedback for recording stop
play_feedback_sound(app, SoundType::Stop);

Expand Down
Loading