Refactor vehicle type resolution for CreateVehicleServerSetter - #1137
Open
DevPorphirio wants to merge 2 commits into
Open
Refactor vehicle type resolution for CreateVehicleServerSetter#1137DevPorphirio wants to merge 2 commits into
DevPorphirio wants to merge 2 commits into
Conversation
Extract vehicle type resolution into a dedicated helper to improve readability and maintainability. This change preserves the current behavior while centralizing the logic used to determine the vehicle type required by CreateVehicleServerSetter(). Also improves the documentation around the mismatchedTypes lookup table and adds defensive handling for unexpected vehicle classes, making future GTA DLC additions easier to diagnose.
- Add missing vehicle type overrides: - driftkeitora - towtruck3 - towtruck4 - Reorder mismatchedTypes entries alphabetically for readability. - Keep vehicle type corrections aligned with current GTA V Enhanced vehicle metadata.
|
DIDOS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the client-side vehicle type resolution used by
CreateVehicleServerSetter().No functional changes are intended.
Changes
mismatchedTypes.This should make future maintenance easier as new GTA DLC vehicles are introduced.