fix(server/state): update last occupant for given seat index even if was taken - #4084
Open
drakeee wants to merge 1 commit into
Open
fix(server/state): update last occupant for given seat index even if was taken#4084drakeee wants to merge 1 commit into
drakeee wants to merge 1 commit into
Conversation
…it was taken already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
There are a lot of seat ejection happening. Cheater able to force out already seated players in given vehicles. The problem is that
GetLastPedInVehicleSeatwouldn't return the cheater ped, because there is an if check if the seat is free and won't modify the last occupant array for the vehicle.How is this PR achieving the goal
Current occupants for the vehicle would be the same, last occupants skip the if check.
This PR applies to the following area(s)
Server
Successfully tested on
Game builds: 3258
Platforms: Windows
Checklist
Fixes issues