Skip to content

[ENH]: Add a different config struct to load without disk intermediary #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanujnay112 merged 1 commit into from
Sep 8, 2025
Merged

[ENH]: Add a different config struct to load without disk intermediary #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/hnsw.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,12 @@ pub struct HnswIndexLoadConfig {
pub ef_search: usize,
}

pub struct HnswIndexMemoryLoadConfig {
pub distance_function: HnswDistanceFunction,
pub dimensionality: i32,
pub ef_search: usize,
}

pub struct HnswIndexInitConfig {
pub distance_function: HnswDistanceFunction,
pub dimensionality: i32,
Expand Down Expand Up @@ -367,7 +373,7 @@ impl HnswIndex {
}

/// Load index from memory buffers
pub fn load_from_hnsw_data(config: HnswIndexLoadConfig, load_data: HnswData) -> Result<Self, HnswInitError> {
pub fn load_from_hnsw_data(config: HnswIndexMemoryLoadConfig, load_data: HnswData) -> Result<Self, HnswInitError> {
let distance_function_string: String = config.distance_function.into();
let space_name = CString::new(distance_function_string)
.map_err(|e| HnswInitError::InvalidDistanceFunction(e.to_string()))?;
Expand Down Expand Up @@ -939,10 +945,9 @@ pub mod test {
.link_list_buffer(src_buffers[3].clone())
.build();

let index = HnswIndex::load_from_hnsw_data(HnswIndexLoadConfig {
let index = HnswIndex::load_from_hnsw_data(HnswIndexMemoryLoadConfig {
distance_function,
dimensionality: d as i32,
persist_path: "".into(),
ef_search: 100,
}, hnsw_data.expect("Failed to create HnswData"));

Expand Down Expand Up @@ -1011,10 +1016,9 @@ pub mod test {

// Create new index from memory buffers
let loaded_index = HnswIndex::load_from_hnsw_data(
HnswIndexLoadConfig {
HnswIndexMemoryLoadConfig {
distance_function,
dimensionality: d as i32,
persist_path: "".into(),
ef_search: 100,
},
hnsw_data,
Expand Down
Loading