Skip to content

Lower matrix dot fix #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrhansk merged 2 commits into from
Dec 21, 2025
Merged

Lower matrix dot fix #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f3459f
dot product for lower triangular and not symetric matrix is needed
Zvmcevap Dec 14, 2025
92c075d
extension should not matter (unless zipped file) will error out in `o…
Zvmcevap Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/pyqplib/lower_mat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ def dot(self, x):

for row, col, val in zip(subdiag_rows, subdiag_cols, subdiag_vals):
p[row] += val * x[col]
p[col] += val * x[row]

diag_vals = self.diag_vals
diag_rows = self.diag_rows
Expand Down
8 changes: 3 additions & 5 deletions src/pyqplib/reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,15 +318,13 @@ def open_file(filename):

path, extension = os.path.splitext(filename)

if extension == ".qplib":
return open(filename, "r")

elif extension == ".zip":
if extension == ".zip":
basename = os.path.basename(path)
return zipfile.Path(filename, at=basename).open("r")

raise ValueError(f"Unknown extension {extension}")

return open(filename, "r")

def _read_from(filename, read_problem):
logger.info(f"Reading QPLIB instance from {filename}")
Expand Down
Loading