Skip to content

(tests) Update Pester tests #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
corbob wants to merge 2 commits into
base: develop
Choose a base branch
from
+12 −2
Draft

(tests) Update Pester tests #3906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ca4359
(tests) Disable other sources on upgrade all tests
corbob Jun 1, 2026
3863e1d
(tests) Account for different push messages
corbob Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tests/pester-tests/commands/choco-push.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,13 @@ Describe "choco push" -Tag Chocolatey, PushCommand, ProxySkip, CCR -Skip:($null
}

It "Should Report the actual cause of the error" {
$expectedErrors = @(
"Response status code does not indicate success: 409 (This package had an issue pushing: A nuget package's Description property may not be more than 4000 characters long.)." # Direct
"Response status code does not indicate success: 409 (Conflict)." # Indirect
)
$Output.Lines | Should -Contain "Attempting to push $PackageUnderTest.$VersionUnderTest.nupkg to $RepositoryToUse" -Because $Output.String
$Output.Lines | Should -Contain "An error has occurred. It's possible the package version already exists on the repository or a nuspec element is invalid. See error below..." -Because $Output.String
$Output.Lines | Should -Contain "Response status code does not indicate success: 409 (This package had an issue pushing: A nuget package's Description property may not be more than 4000 characters long.)." -Because $Output.String
$Output.Lines -contains $expectedErrors | Should -BeTrue -Because $Output.String
}
}

Expand Down Expand Up @@ -108,9 +112,13 @@ Describe "choco push" -Tag Chocolatey, PushCommand, ProxySkip, CCR -Skip:($null
}

It "Should Report the actual cause of the error" {
$expectedErrors = @(
"Response status code does not indicate success: 409 (This package had an issue pushing: A nuget package's Title property may not be more than 256 characters long.)." #Direct
"Response status code does not indicate success: 409 (Conflict)." # Indirect
)
$Output.Lines | Should -Contain "Attempting to push $PackageUnderTest.$VersionUnderTest.nupkg to $RepositoryToUse" -Because $Output.String
$Output.Lines | Should -Contain "An error has occurred. It's possible the package version already exists on the repository or a nuspec element is invalid. See error below..." -Because $Output.String
$Output.Lines | Should -Contain "Response status code does not indicate success: 409 (This package had an issue pushing: A nuget package's Title property may not be more than 256 characters long.)." -Because $Output.String
$Output.Lines -contains $expectedErrors | Should -BeTrue -Because $Output.String
}
}

Expand Down
2 changes: 2 additions & 0 deletions tests/pester-tests/commands/choco-upgrade.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
BeforeAll {
Remove-NuGetPaths
Initialize-ChocolateyTestInstall
Disable-ChocolateySource -All
Enable-ChocolateySource -Name hermes

New-ChocolateyInstallSnapshot
$features = Get-ChocolateyFeatures
Expand Down
Loading