Add support for #[derive(Debug, serde::Serialize, serde::Deserialize)] to SharedStruct#248
Open
wooden-worm wants to merge 2 commits intochinedufn:masterfrom
Open
Add support for #[derive(Debug, serde::Serialize, serde::Deserialize)] to SharedStruct#248wooden-worm wants to merge 2 commits intochinedufn:masterfrom
wooden-worm wants to merge 2 commits intochinedufn:masterfrom
Conversation
Owner
|
Looks like the right direction |
Author
|
I added a few tests, let me know if I missed anything. |
|
@wooden-worm are you still working on this PR? I could really use this feature, and I'd be happy to help move this forward. |
Author
|
I've added a few tests, not sure what else this needs in order to merge? |
|
@wooden-worm thanks for the quick reply. @chinedufn are there any other required changes before this can be merged? |
Owner
|
I'll take a look over the weekend. |
|
I am in dire need to be able to have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanding on #198
Let me know if this is heading toward the right direction, I can add more tests later.