Skip to content

[codex] steer busy text by default - #839

Open
juanfradb wants to merge 1 commit into
chenhg5:mainfrom
juanfradb:codex/default-busy-turn-steer
Open

[codex] steer busy text by default#839
juanfradb wants to merge 1 commit into
chenhg5:mainfrom
juanfradb:codex/default-busy-turn-steer

Conversation

@juanfradb

Copy link
Copy Markdown

Summary

  • default busy plain-text messages to same-turn steering instead of enqueueing for later
  • add display.busy_input_mode = "queue" as an opt-out for the previous queue behavior
  • wire Codex app-server sessions to native turn/steer with the active expectedTurnId

Behavior

Plain text sent while a session is busy now uses the active turn when steering is available. Empty messages, media/file messages, unavailable sessions, failed steering, and explicit busy_input_mode = "queue" continue to use the existing busy queue fallback.

Related but not duplicate: #523 adds an opt-in busy action mode, #669 adds an explicit /steer command, and #707 handles pre-execution message collection while leaving in-flight continuation unchanged.

Validation

  • go test ./config ./core ./agent/codex ./cmd/cc-connect

@chenhg5 chenhg5 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Codex steer busy text by default,CI pass,测试覆盖。

@juanfradb
juanfradb force-pushed the codex/default-busy-turn-steer branch from 1d65bd1 to c6c8ad5 Compare May 12, 2026 14:07
@juanfradb
juanfradb force-pushed the codex/default-busy-turn-steer branch from c6c8ad5 to 04f6d49 Compare May 12, 2026 14:17
@juanfradb
juanfradb marked this pull request as ready for review May 12, 2026 14:18
@chenhg5 chenhg5 added P2 P2: 一般需求 / 优化 agent-codex Codex相关 enhancement New feature or request pr-conflicting PR has merge conflicts and needs rebase or closure pr-needs-review PR needs maintainer or QA review labels Jun 6, 2026
@ternary-chen

Copy link
Copy Markdown

Thanks for the earlier work here. I opened #1652 as a Draft based on the current main after testing the same busy-input path with Feishu and the Codex app-server backend.

The draft keeps queue as the backward-compatible default and makes steer opt-in. It also adds a capability-based interface, expectedTurnId protection, fallback to the existing queue, queue-only handling for attachments, history/watermark persistence, CUJ and targeted race coverage, and safer /ps behavior.

This clearly overlaps #839. I am not treating #1652 as an automatic replacement — happy to align, split, or close it if the author or maintainers prefer reviving this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-codex Codex相关 enhancement New feature or request P2 P2: 一般需求 / 优化 pr-conflicting PR has merge conflicts and needs rebase or closure pr-needs-review PR needs maintainer or QA review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants