fix(codex): steer active turns for /ps guidance - #1530
Closed
AaronZ345 wants to merge 6 commits into
Closed
Conversation
AaronZ345
force-pushed
the
agent/fix-codex-ps-steer
branch
2 times, most recently
from
July 14, 2026 03:02
d194f28 to
8108fbc
Compare
Contributor
Author
|
Hi @chenhg5, I’ve rebased this PR onto the latest main and all five CI checks are green. Could you please take another look and merge it when you have a chance? Thanks! |
AaronZ345
force-pushed
the
agent/fix-codex-ps-steer
branch
2 times, most recently
from
July 19, 2026 14:42
9c5df29 to
53bf7e5
Compare
AaronZ345
force-pushed
the
agent/fix-codex-ps-steer
branch
2 times, most recently
from
July 25, 2026 14:41
e08b746 to
eb7186b
Compare
AaronZ345
force-pushed
the
agent/fix-codex-ps-steer
branch
from
August 6, 2026 14:43
eb7186b to
4b878e7
Compare
AaronZ345
force-pushed
the
agent/fix-codex-ps-steer
branch
from
August 7, 2026 14:42
4b878e7 to
0268deb
Compare
Contributor
Author
|
Superseded by #1665. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turn/steerinstead of starting a second turn/psguidanceturn/startbehavior for idle sessions and reject mismatched steering responsesWhy
/pscallsAgentSession.Sendwhile the current turn is still running. The Codex app-server implementation previously treated everySendasturn/start, reset the active-turn state, and cleared buffered messages. That race could emit an empty result even though Codex later completed a full answer.Codex exposes
turn/steerfor same-turn guidance. This change uses it with the activeexpectedTurnId, matching Codex's native guidance behavior without turning the guidance into a separate user turn.Testing
go test ./...go test -race ./agent/codex ./core ./platform/cloud-webgo vet ./...go build ./...turn/steerrequest and response fields