Skip to content

Lazily load mixlib-shellout #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tas50 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Lazily load mixlib-shellout #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/mixlib/install.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#

require "mixlib/versioning"
require "mixlib/shellout" unless defined?(Mixlib::ShellOut)

require_relative "install/backend"
require_relative "install/options"
Expand Down Expand Up @@ -252,6 +251,12 @@ def detect_platform
# Returns a Hash containing the platform info options
#
def self.detect_platform
# mixlib-shellout (and the etc, fileutils, tmpdir and fcntl trees it
# pulls in) is only needed to shell out for platform detection, so it is
# loaded here rather than at require time.
require "mixlib/shellout" unless defined?(Mixlib::ShellOut)
require "tmpdir"

output = if Gem.win_platform?
# For Windows we write the detect platform script and execute the
# powershell.exe program with Mixlib::ShellOut
Expand Down
1 change: 1 addition & 0 deletions spec/functional/mixlib/install/cli_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

require "spec_helper"
require "mixlib/install/cli"
require "mixlib/shellout"
require "tmpdir"

describe "mixlib-install executable" do
Expand Down
Loading