Fix in_bulk leaking thread local on exception - #25
Merged
Conversation
If the block passed to Gouda.in_bulk raised, the Thread.current[:gouda_bulk_buffer] was never reset to nil, causing all subsequent perform_later calls to silently buffer into a stale array and never actually enqueue. Wrap the outermost call in an ensure block to guarantee cleanup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
@jujustayfly @svanhesteren please do merge this, it's pretty serious |
Contributor
|
Good point. Thanks for noticing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the block passed to Gouda.in_bulk raised, the
Thread.current[:gouda_bulk_buffer]was never reset to nil, causing all subsequent perform_later calls to silently buffer into a stale array and never actually enqueue. This could lead to jobs silently disappearing without enqueue and this would stay sticky inside the thread until another in_bulk call would be made.Wrap the outermost call in an ensure block to guarantee cleanup.