Run the suite without minitest/mock - #14
Open
khalilgharbaoui wants to merge 1 commit into
Open
Conversation
Minitest 6 moved Minitest::Mock, and with it Object#stub, into a gem of its own, so the test helper could not even require and the suite did not boot on any Ruby which resolves minitest 6. The one place which stubbed - swapping the token encryptor - now does it by hand in four lines. Verified on minitest 6.0.6 with no pin: 72 runs, 0 failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test helper requires
minitest/mock, which minitest 6 moved into a gem of its own, so on any Ruby which resolves minitest 6 (Ruby 4.0 does) the helper cannot require and the suite does not boot at all.The only place which needed it stubbed the token encryptor in one test. That now happens by hand in four lines, so nothing has to be pinned and the suite runs on minitest 5 and 6 alike.
Verified on minitest 6.0.6 with no pin: 72 runs, 159 assertions, 0 failures.