Merged
Conversation
Member
|
A couple of things:
|
Contributor
Author
|
Thanks @sorccu ! Will get to it |
Member
|
Also, include a link to the go sdk PR in the description so that the issues get linked nicely. |
pmallol
force-pushed
the
pmallol/tree-736-check-description
branch
2 times, most recently
from
fbc75ac to
e79f4f6
Compare
pmallol
commented
Apr 15, 2026
Contributor
Author
There was a problem hiding this comment.
@sorccu Not sure if it is necessary to update both the original resource as well, like heartbeats, tcp_check, etc
pmallol
commented
Apr 16, 2026
| } | ||
|
|
||
| func optionalStringPointerFromResourceData(d *schema.ResourceData, key string) *string { | ||
| value, ok := d.GetOk(key) |
Contributor
Author
There was a problem hiding this comment.
GetOkExists is deprecated, using GetOk instead
sorccu
force-pushed
the
pmallol/tree-736-check-description
branch
from
3d8b9f5 to
79af8c9
Compare
The Terraform Plugin SDK's ResourceData.Set already dereferences pointer types and normalizes nil pointers via reflection, so the custom setOptionalStringResourceData helper was unnecessary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
d.Set(key, nil) always stores "" in state for TypeString, so the removal tests can use TestCheckResourceAttr with "" directly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
GetOk already returns false for zero-value strings, so the str == "" guard in optionalStringPointerFromResourceData is unreachable. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sorccu
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected Components
Pre-Requisites
terraform fmtgo fmtplan&applycommand ofdemo/main.tffile do not produce diffsNotes for the Reviewer
This adds top-level
descriptionsupport to the legacycheckly_checkresource, the newer monitor resources (checkly_url_monitor,checkly_tcp_monitor,checkly_dns_monitor,checkly_icmp_monitor,checkly_heartbeat_monitor), andcheckly_playwright_check_suite.The PR also adds acceptance coverage for description set/remove behavior and regenerates the provider docs.
SDK: checkly/checkly-go-sdk#155