automate and improve change-tracking in deployers#869
Merged
Conversation
hpk42
temporarily deployed
to
staging-ipv4.testrun.org
GitHub Actions
Inactive
hpk42
temporarily deployed
to
staging2.testrun.org
GitHub Actions
Inactive
hpk42
changed the title
hpk42
force-pushed
the
hpk/tls-external
branch
from
d252967 to
19249b8
Compare
hpk42
force-pushed
the
hpk/refactor-deployers
branch
from
7831333 to
c891c27
Compare
hpk42
temporarily deployed
to
staging2.testrun.org
GitHub Actions
Inactive
hpk42
force-pushed
the
hpk/tls-external
branch
from
19249b8 to
821ae5b
Compare
hpk42
force-pushed
the
hpk/refactor-deployers
branch
from
c891c27 to
2e69a25
Compare
hpk42
temporarily deployed
to
staging2.testrun.org
GitHub Actions
Inactive
hpk42
temporarily deployed
to
staging-ipv4.testrun.org
GitHub Actions
Inactive
hpk42
force-pushed
the
hpk/tls-external
branch
3 times, most recently
from
3f05a9a to
cf7e9fd
Compare
hpk42
force-pushed
the
main
branch
2 times, most recently
from
92a52b9 to
e21f2a0
Compare
hpk42
force-pushed
the
hpk/refactor-deployers
branch
from
2e69a25 to
36e8133
Compare
hpk42
temporarily deployed
to
staging-ipv4.testrun.org
GitHub Actions
Inactive
hpk42
temporarily deployed
to
staging2.testrun.org
GitHub Actions
Inactive
hpk42
force-pushed
the
hpk/refactor-deployers
branch
from
36e8133 to
4302126
Compare
hpk42
had a problem deploying
to
staging-ipv4.testrun.org
GitHub Actions
Failure
hpk42
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Failure
hpk42
force-pushed
the
hpk/refactor-deployers
branch
4 times, most recently
from
fc8c8e3 to
486fb47
Compare
hpk42
changed the title
hpk42
force-pushed
the
hpk/refactor-deployers
branch
from
486fb47 to
d911e85
Compare
hpk42
force-pushed
the
hpk/refactor-deployers
branch
from
d911e85 to
dac6526
Compare
hpk42
changed the title
hpk42
force-pushed
the
hpk/refactor-deployers
branch
from
dac6526 to
72871d7
Compare
hpk42
changed the title
hpk42
force-pushed
the
hpk/refactor-deployers
branch
5 times, most recently
from
2fae992 to
dfa0315
Compare
hpk42
force-pushed
the
hpk/refactor-deployers
branch
2 times, most recently
from
1008981 to
76f00da
Compare
j4n
approved these changes
May 6, 2026
Contributor
j4n
left a comment
j4n
left a comment
There was a problem hiding this comment.
Looks good to me, a few minor suggestions.
Tested deploying, re-deploying, and redeploy with modified system units, all good.
It makes me wish to have a pyinfra_helpers.py we could use in other repos as well, with just the wrapper functions :)
| return self.put_template(src, dest, **kwargs) | ||
| return self.put_file(src, dest) | ||
|
|
||
| def put_file(self, src, dest, mode="644"): |
Contributor
There was a problem hiding this comment.
Suggested change
| def put_file(self, src, dest, mode="644"): | |
| def put_file(self, src, dest, mode="644", reason=None): |
I think it would be valuable to preserve the ability to explain changes for put_file, put_template, remove_file, and embed it in braces into the name parameter.
| return self.put_template(src, dest, **kwargs) | ||
| return self.put_file(src, dest) | ||
|
|
||
| def put_file(self, src, dest, mode="644"): |
Contributor
There was a problem hiding this comment.
also, this takes mode as an argument, but template doesnt, but takes owner - maybe this should be symmetrical to be less confusing.
Contributor
Author
There was a problem hiding this comment.
The new API is meant to only consists of things that map the previous usage, nothing more. If some other argument is needed, it is easy enough to add when it is actually needed.
| dest = f"/etc/systemd/system/{dest_name}" | ||
| if src.endswith(".j2"): | ||
| return self.put_template(src, dest, **kwargs) | ||
| return self.put_file(src, dest) |
Contributor
There was a problem hiding this comment.
maybe we should pass kwargs to the non-template-case, to honor dest_name for example.
hpk42
force-pushed
the
hpk/refactor-deployers
branch
from
76f00da to
a1d5e3d
Compare
Contributor
Author
|
a more general API or |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automate change tracking for added/remove files and systemd services. This removes a lot of boilerplate from the deployers and makes them more readable and less error-prone.