Aggressive LMTP header cleanup#816
Conversation
feld
had a problem deploying
to
staging-ipv4.testrun.org
GitHub Actions
Failure
feld
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Failure
|
We should deploy this on ci-chatmail.testrun.org before merging, to run core CI against it. @link2xt do we need to do anything for this other than |
|
This will break message previews in the new core because of unencrypted |
|
I don't want to merge this until several core members are very confident this will not break anything. We can just continue iterating and thinking about whether the test coverage we have is sufficient and what the downsides may be as we continue the journey to remove all possible plaintext metadata from relay storage. Does anyone know why we need the "From" header? |
feld
had a problem deploying
to
staging-ipv4.testrun.org
GitHub Actions
Error
feld
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Error
|
could you add content-type and rebase, so we can see what fails in the cmlxc runs? |
done, let's see how it goes |
tests are going to fail due to this, so I'll add Subject back in to see if it gets further. Maybe a "refute Subject in..." will be appropriate if everything else works |
This will remove all headers possible during LMTP delivery. From: required or clients do not process the message correctly Message-Id: required for clients to know which messages have been downloaded Chat-Is-Post-Message: is required for our attachment previews Content-Type: required (??) Subject: required due to test assertions
4 participants
This will remove all headers possible during LMTP delivery.
From header: required or clients do not process the message correctly
Message-Id header: required for clients to know which messages have been downloaded